[WPE] Disable FTP directory support by default

[blino]

0655304

[WPE] Disable FTP directory support by default
https://bugs.webkit.org/show_bug.cgi?id=241094

Reviewed by Adrian Perez de Castro.

* Source/cmake/OptionsWPE.cmake:
FTP directory support is disabled by default in the GTK port, and has
been removed in major browsers (Firefox, Chrome).
Disabling it also saves 24 kB on the library size for an ARMv7 build.

Canonical link: https://commits.webkit.org/251865@main

[aperezdc]

I have no strong opinion about changing the default, but I suppose it's not much of a hassle to disable it by hand when doing a custom build either.

Opinions @philn, @zdobersek, @magomez?

[blino]

I have no strong opinion about changing the default, but I suppose it's not much of a hassle to disable it by hand when doing a custom build either.

This change is mostly to align with the GTK port defaults, and with other browsers which removed FTP support in the past year because of poor protocol security.

And for WPE which mostly targets embedded targets, printing the content of a FTP directory is not really useful.

[philn]

No objection. BTW unrelated, the API tests are broken (webkit-settings, java stuff).

[blino]

No objection. BTW unrelated, the API tests are broken (webkit-settings, java stuff).

Maybe related to #1098 ?
cc @lauromoura

[aperezdc]

No objection. BTW unrelated, the API tests are broken (webkit-settings, java stuff).

Maybe related to #1098 ? cc @lauromoura

Yes, that was the patch shuffling around the API tests for the Java setting. The failures are independent from the change introduced by this patch.

[webkit-commit-queue]

Committed 251865@main (0655304): https://commits.webkit.org/251865@main

Reviewed commits have been landed. Closing PR #1153 and removing active labels.