Skip to content

Conversation

lauromoura
Copy link
Contributor

@lauromoura lauromoura commented May 27, 2022

8ee445d

[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538

Reviewed by Adrian Perez de Castro.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings): Move test of deprecated function to section
disabling deprecation warnings.

Canonical link: https://commits.webkit.org/251052@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@lauromoura lauromoura self-assigned this May 27, 2022
@lauromoura lauromoura added WebKit Nightly Build WebKitGTK Bugs related to the Gtk API layer. labels May 27, 2022
@mcatanzaro
Copy link
Contributor

It seems the GTK EWS is going slow and hasn't posted results yet.

This will surely fix the warnings from GCC, but it also removes the guards blocking the test from failing on runtime warnings from GLib, so my guess is it breaks the test?

@lauromoura
Copy link
Contributor Author

This will surely fix the warnings from GCC, but it also removes the guards blocking the test from failing on runtime warnings from GLib, so my guess is it breaks the test?

You're right. Somehow I missed it, sorry.

@lauromoura lauromoura added the merging-blocked Applied to prevent a change from being merged label May 27, 2022
@mcatanzaro
Copy link
Contributor

The runtime warnings are arguably more annoying than useful, so feel free to remove them IMO.

Developers should notice -Wdeprecated-declarations warnings. Meanwhile, users who see runtime warnings can't do anything about them. We do have runtime warnings for the deprecated properties, but only when extra diagnostics are enabled, and still only because there's no way to tell the compiler to warn when a deprecated GObject property is used.

@lauromoura lauromoura removed merging-blocked Applied to prevent a change from being merged WebKitGTK Bugs related to the Gtk API layer. WebKit Nightly Build labels May 27, 2022
@lauromoura lauromoura force-pushed the glib_deprecate_enable_java_warnings branch from 4175b19 to 79929ce Compare May 27, 2022 16:07
@lauromoura lauromoura added WebKit Nightly Build WebKitGTK Bugs related to the Gtk API layer. labels May 27, 2022
@mcatanzaro
Copy link
Contributor

This looks fine now.

@lauromoura lauromoura added the merge-queue Applied to send a pull request to merge-queue label May 27, 2022
@mcatanzaro mcatanzaro added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels May 27, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the glib_deprecate_enable_java_warnings branch from 79929ce to 8ee445d Compare May 27, 2022 17:58
@webkit-early-warning-system webkit-early-warning-system merged commit 8ee445d into WebKit:main May 27, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294942 (251052@main): https://commits.webkit.org/251052@main

Reviewed commits have been landed. Closing PR #1098 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 27, 2022
@lauromoura lauromoura deleted the glib_deprecate_enable_java_warnings branch May 28, 2022 03:36
guijemont pushed a commit to guijemont/WebKit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants