-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[GTK] Deprecate WebKitSettings:enable-java #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTK] Deprecate WebKitSettings:enable-java #1098
Conversation
It seems the GTK EWS is going slow and hasn't posted results yet. This will surely fix the warnings from GCC, but it also removes the guards blocking the test from failing on runtime warnings from GLib, so my guess is it breaks the test? |
You're right. Somehow I missed it, sorry. |
The runtime warnings are arguably more annoying than useful, so feel free to remove them IMO. Developers should notice -Wdeprecated-declarations warnings. Meanwhile, users who see runtime warnings can't do anything about them. We do have runtime warnings for the deprecated properties, but only when extra diagnostics are enabled, and still only because there's no way to tell the compiler to warn when a deprecated GObject property is used. |
4175b19
to
79929ce
Compare
This looks fine now. |
79929ce
to
8ee445d
Compare
Committed r294942 (251052@main): https://commits.webkit.org/251052@main Reviewed commits have been landed. Closing PR #1098 and removing active labels. |
…-2-38 Improve memory pressure logging
8ee445d