Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Make GitHubMixin.get_pr_json asynchronous #11954

Commits on Mar 27, 2023

  1. [ews-build.webkit.org] Make GitHubMixin.get_pr_json asynchronous

    https://bugs.webkit.org/show_bug.cgi?id=254446
    rdar://107207345
    
    Reviewed by Aakash Jain.
    
    * Tools/CISupport/ews-build/steps.py:
    (GitHubMixin):
    (GitHubMixin.get_pr_json): Use Twisted's asynchronous request library
    and make function asynchronous.
    (GitHubMixin.should_send_email_for_pr): get_pr_json is not asynchronous.
    (ValidateChange.validate_github): Ditto.
    (BlockPullRequest.run): Ditto.
    (GitHubMixin.fetch_data_from_url_with_authentication_github_old): Deleted.
    
    Canonical link: https://commits.webkit.org/262151@main
    JonWBedard committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    9a18fa3 View commit details
    Browse the repository at this point in the history