[ews-build.webkit.org] Make GitHubMixin.get_pr_json asynchronous #11954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 2933745) |
aj062
reviewed
Mar 27, 2023
This one has been live on the UAT instance all weekend: https://ews-build.webkit-uat.org/#/builders/4/builds/7580 |
JonWBedard
added
unsafe-merge-queue
Actually, scratch that, I see why you bring that up in this PR. You're right, this is the more appropriate place to fix this deficiency. |
JonWBedard
force-pushed
the
eng/ews-build-webkit-org-Make-GitHubMixin-get_pr_json-asynchronous
branch
from
2933745
to
7e8886c
Compare
JonWBedard
added
skip-ews
|
EWS run on current version of this PR (hash 7e8886c)
|
https://bugs.webkit.org/show_bug.cgi?id=254446 rdar://107207345 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (GitHubMixin): (GitHubMixin.get_pr_json): Use Twisted's asynchronous request library and make function asynchronous. (GitHubMixin.should_send_email_for_pr): get_pr_json is not asynchronous. (ValidateChange.validate_github): Ditto. (BlockPullRequest.run): Ditto. (GitHubMixin.fetch_data_from_url_with_authentication_github_old): Deleted. Canonical link: https://commits.webkit.org/262151@main
webkit-commit-queue
force-pushed
the
eng/ews-build-webkit-org-Make-GitHubMixin-get_pr_json-asynchronous
branch
from
7e8886c
to
9a18fa3
Compare
|
Committed 262151@main (9a18fa3): https://commits.webkit.org/262151@main Reviewed commits have been landed. Closing PR #11954 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/ews-build-webkit-org-Make-GitHubMixin-get_pr_json-asynchronous
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9a18fa3
7e8886c
🧪 style🛠 ios🛠 mac🛠 wpe🛠 wincairo🧪 bindings🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🛠 gtk🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🛠 tv🧪 mac-wk2🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2🧪 services🛠 watch🧪 mac-wk2-stress🛠 watch-sim