Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ews-build] Make should_send_email_for_patch asynchronous #11958

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[ews-build] Make should_send_email_for_patch asynchronous #11958

merged 1 commit into from
Apr 20, 2023

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 25, 2023 •
edited by webkit-early-warning-system
Loading

b98dad5

[ews-build] Make should_send_email_for_patch asynchronous
https://bugs.webkit.org/show_bug.cgi?id=254450
rdar://107209666

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.should_send_email_for_patch): Make asynchronous.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Treat
should_send_email_for_patch as asynchronous.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

Canonical link: https://commits.webkit.org/263175@main

d28059c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@JonWBedard JonWBedard self-assigned this Mar 25, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 25, 2023 •
edited
Loading

EWS run on previous version of this PR (hash d611731)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@JonWBedard JonWBedard mentioned this pull request Mar 27, 2023
Merged
@JonWBedard JonWBedard force-pushed the eng/ews-build-Make-should_send_email_for_patch-asynchronous branch from d611731 to d28059c Compare April 19, 2023 18:40
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 19, 2023 •
edited
Loading

EWS run on current version of this PR (hash d28059c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 20, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 20, 2023
@JonWBedard JonWBedard added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Apr 20, 2023
@JonWBedard
[ews-build] Make should_send_email_for_patch asynchronous
b98dad5 
https://bugs.webkit.org/show_bug.cgi?id=254450
rdar://107209666

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.should_send_email_for_patch): Make asynchronous.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Treat
should_send_email_for_patch as asynchronous.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

Canonical link: https://commits.webkit.org/263175@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ews-build-Make-should_send_email_for_patch-asynchronous branch from d28059c to b98dad5 Compare April 20, 2023 15:05
@webkit-commit-queue
Copy link
Collaborator

Committed 263175@main (b98dad5): https://commits.webkit.org/263175@main

Reviewed commits have been landed. Closing PR #11958 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 20, 2023
@webkit-commit-queue webkit-commit-queue merged commit b98dad5 into WebKit:main Apr 20, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-Make-should_send_email_for_patch-asynchronous branch May 4, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@JonWBedard @webkit-early-warning-system @webkit-commit-queue @aj062 @webkit-ews-buildbot