Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSC] Bound function name should be resolved #11991

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Mar 27, 2023

4c1d077

[JSC] Bound function name should be resolved
https://bugs.webkit.org/show_bug.cgi?id=254499
rdar://107243150

Reviewed by Ross Kirsling.

JSBoundFunction's name needs to be resolved string.
This patch fixes the case which sets JSRopeString to the name's field.

* JSTests/stress/bound-function-name-rope.js: Added.
(shouldBe):
(test):
* Source/JavaScriptCore/runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::nameSlow):

Canonical link: https://commits.webkit.org/262139@main

b881909

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner March 27, 2023 06:19
@Constellation Constellation self-assigned this Mar 27, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Mar 27, 2023
Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation
Copy link
Member Author

Thanks!

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 27, 2023
https://bugs.webkit.org/show_bug.cgi?id=254499
rdar://107243150

Reviewed by Ross Kirsling.

JSBoundFunction's name needs to be resolved string.
This patch fixes the case which sets JSRopeString to the name's field.

* JSTests/stress/bound-function-name-rope.js: Added.
(shouldBe):
(test):
* Source/JavaScriptCore/runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::nameSlow):

Canonical link: https://commits.webkit.org/262139@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Bound-function-name-should-be-resolved branch from b881909 to 4c1d077 Compare March 27, 2023 08:51
@webkit-commit-queue
Copy link
Collaborator

Committed 262139@main (4c1d077): https://commits.webkit.org/262139@main

Reviewed commits have been landed. Closing PR #11991 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4c1d077 into WebKit:main Mar 27, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 27, 2023
@Constellation Constellation deleted the eng/JSC-Bound-function-name-should-be-resolved branch March 27, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants