Reimplement the progress display in wide-layout attachments #12424

squelart · 2023-04-05T21:03:16Z

`31c3e79`

Reimplement the progress display in wide-layout attachments
https://bugs.webkit.org/show_bug.cgi?id=255100
rdar://problem/107716507

Reviewed by Aditya Keerthi.

When a wide-layout attachment has an attribute "progress" with a number, it is now directly handled by the top-level attachment element, by displaying a pie chart; previously it was handled by the inner attachment's legacy code.

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::attachmentProgressIdentifier):
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::updateProgress):
(WebCore::HTMLAttachmentElement::parseAttribute):
* Source/WebCore/html/HTMLAttachmentElement.h:
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-progress):

Canonical link: https://commits.webkit.org/262758@main

558cd0c

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 api-ios	✅ 🧪 api-gtk
	✅ 🧪 mac-wk2	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-05T21:11:06Z

EWS run on previous version of this PR (hash ed6b445)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-06T18:29:39Z

EWS run on previous version of this PR (hash c86f6a4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-06T20:16:47Z

EWS run on previous version of this PR (hash 2d4e5f1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Source/WebCore/html/HTMLAttachmentElement.cpp

pxlcoder · 2023-04-06T20:50:08Z

Source/WebCore/html/shadow/attachmentElementShadow.css

+/* FIXME: Combine border into attachment-progress above, when rdar://107621207 is fixed. */
+div#attachment-progress-circle {


Would we also be able to remove this div entirely when rdar://107621207 is fixed? Other than that, it's not obvious to me why we need both.

Oh, that's what I meant: Move the border styling to the above div, and remove this div. I'll rephrase for clarity...

webkit-early-warning-system · 2023-04-06T21:22:21Z

EWS run on previous version of this PR (hash b51a528)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-06T21:30:59Z

EWS run on previous version of this PR (hash 4ad821d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	✅ 🛠 tv	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

pxlcoder · 2023-04-06T21:34:53Z

Source/WebCore/html/HTMLAttachmentElement.cpp

@@ -54,6 +54,7 @@
 #include <wtf/IsoMallocInlines.h>
 #include <wtf/UUID.h>
 #include <wtf/URLParser.h>
+#include <wtf/text/StringBuilder.h>


This include can be removed now.

pxlcoder · 2023-04-06T21:35:40Z

Please move this out of draft status prior to merging (I wonder if it will even let you merge?).

webkit-early-warning-system · 2023-04-06T21:45:14Z

EWS run on current version of this PR (hash 558cd0c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 api-ios	✅ 🧪 api-gtk
	✅ 🧪 mac-wk2	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

squelart · 2023-04-06T22:10:55Z

Please move this out of draft status prior to merging (I wonder if it will even let you merge?).

Strange, I don't remember making it a draft!? Anyway, back to normal now. I'll let the tests finish before merging...

cdumez · 2023-04-06T22:14:39Z

Please move this out of draft status prior to merging (I wonder if it will even let you merge?).

It wouldn't let you merge in my experience.

https://bugs.webkit.org/show_bug.cgi?id=255100 rdar://problem/107716507 Reviewed by Aditya Keerthi. When a wide-layout attachment has an attribute "progress" with a number, it is now directly handled by the top-level attachment element, by displaying a pie chart; previously it was handled by the inner attachment's legacy code. * Source/WebCore/html/HTMLAttachmentElement.cpp: (WebCore::attachmentProgressIdentifier): (WebCore::HTMLAttachmentElement::ensureModernShadowTree): (WebCore::HTMLAttachmentElement::updateProgress): (WebCore::HTMLAttachmentElement::parseAttribute): * Source/WebCore/html/HTMLAttachmentElement.h: * Source/WebCore/html/shadow/attachmentElementShadow.css: (div#attachment-progress): Canonical link: https://commits.webkit.org/262758@main

webkit-commit-queue · 2023-04-09T09:28:11Z

Committed 262758@main (31c3e79): https://commits.webkit.org/262758@main

Reviewed commits have been landed. Closing PR #12424 and removing active labels.

squelart self-assigned this Apr 5, 2023

squelart force-pushed the eng/attachment-progress-pie branch from ed6b445 to c86f6a4 Compare April 6, 2023 18:29

squelart added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Apr 6, 2023

squelart force-pushed the eng/attachment-progress-pie branch from c86f6a4 to 2d4e5f1 Compare April 6, 2023 20:16

pxlcoder reviewed Apr 6, 2023

View reviewed changes

squelart force-pushed the eng/attachment-progress-pie branch from 2d4e5f1 to b51a528 Compare April 6, 2023 21:20

squelart force-pushed the eng/attachment-progress-pie branch from b51a528 to 4ad821d Compare April 6, 2023 21:30

pxlcoder approved these changes Apr 6, 2023

View reviewed changes

squelart force-pushed the eng/attachment-progress-pie branch from 4ad821d to 558cd0c Compare April 6, 2023 21:44

squelart marked this pull request as ready for review April 6, 2023 22:09

squelart requested review from cdumez and rniwa as code owners April 6, 2023 22:09

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 7, 2023

squelart added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Apr 7, 2023

webkit-commit-queue force-pushed the eng/attachment-progress-pie branch from 558cd0c to 31c3e79 Compare April 9, 2023 09:28

webkit-commit-queue merged commit 31c3e79 into WebKit:main Apr 9, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reimplement the progress display in wide-layout attachments #12424

Reimplement the progress display in wide-layout attachments #12424

squelart commented Apr 5, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Apr 5, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

pxlcoder Apr 6, 2023 •

edited

squelart Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

pxlcoder Apr 6, 2023

pxlcoder commented Apr 6, 2023

webkit-early-warning-system commented Apr 6, 2023 •

edited

squelart commented Apr 6, 2023 •

edited

cdumez commented Apr 6, 2023

webkit-commit-queue commented Apr 9, 2023

		/* FIXME: Combine border into attachment-progress above, when rdar://107621207 is fixed. */
		div#attachment-progress-circle {

Reimplement the progress display in wide-layout attachments #12424

Reimplement the progress display in wide-layout attachments #12424

Conversation

squelart commented Apr 5, 2023 • edited by webkit-early-warning-system

31c3e79

webkit-early-warning-system commented Apr 5, 2023 • edited

webkit-early-warning-system commented Apr 6, 2023 • edited

webkit-early-warning-system commented Apr 6, 2023 • edited

pxlcoder Apr 6, 2023 • edited

Choose a reason for hiding this comment

squelart Apr 6, 2023 • edited

Choose a reason for hiding this comment

webkit-early-warning-system commented Apr 6, 2023 • edited

webkit-early-warning-system commented Apr 6, 2023 • edited

pxlcoder Apr 6, 2023

Choose a reason for hiding this comment

pxlcoder commented Apr 6, 2023

webkit-early-warning-system commented Apr 6, 2023 • edited

squelart commented Apr 6, 2023 • edited

cdumez commented Apr 6, 2023

webkit-commit-queue commented Apr 9, 2023

squelart commented Apr 5, 2023 •

edited by webkit-early-warning-system

`31c3e79`

webkit-early-warning-system commented Apr 5, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

pxlcoder Apr 6, 2023 •

edited

squelart Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

webkit-early-warning-system commented Apr 6, 2023 •

edited

squelart commented Apr 6, 2023 •

edited