Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the progress display in wide-layout attachments #12424

Merged

Commits on Apr 9, 2023

  1. Reimplement the progress display in wide-layout attachments

    https://bugs.webkit.org/show_bug.cgi?id=255100
    rdar://problem/107716507
    
    Reviewed by Aditya Keerthi.
    
    When a wide-layout attachment has an attribute "progress" with a number, it is now directly handled by the top-level attachment element, by displaying a pie chart; previously it was handled by the inner attachment's legacy code.
    
    * Source/WebCore/html/HTMLAttachmentElement.cpp:
    (WebCore::attachmentProgressIdentifier):
    (WebCore::HTMLAttachmentElement::ensureModernShadowTree):
    (WebCore::HTMLAttachmentElement::updateProgress):
    (WebCore::HTMLAttachmentElement::parseAttribute):
    * Source/WebCore/html/HTMLAttachmentElement.h:
    * Source/WebCore/html/shadow/attachmentElementShadow.css:
    (div#attachment-progress):
    
    Canonical link: https://commits.webkit.org/262758@main
    squelart committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    31c3e79 View commit details
    Browse the repository at this point in the history