Avoid unnecessary StyleColor copying in animation wrappers #12609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 3e7d6aa)
|
|
Cc @weinig who's always interested in color-related things. |
anttijk
changed the title
anttijk
added
the
Animations
graouts
approved these changes
Apr 11, 2023
Comment on lines
1779
to
1780
| auto result = blendFunc(value(from), value(to), context); | ||
| (destination.*m_setter)(result); |
There was a problem hiding this comment.
Bit sad that we can't move this. I guess it gets copied down the line?
anttijk
force-pushed
the
eng/Avoid-unnecessary-StyleColor-copying-in-animation-wrappers
branch
from
3e7d6aa
to
601bc42
Compare
|
EWS run on current version of this PR (hash 601bc42) |
https://bugs.webkit.org/show_bug.cgi?id=255278 rdar://107875297 Reviewed by Antoine Quint. There is some unnecessary copying of this not-quite-trivial type. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::PropertyWrapperStyleColor::PropertyWrapperStyleColor): (WebCore::PropertyWrapperStyleColor::value const): Remove templating and have separate classes for StyleColor and Color cases. (WebCore::PropertyWrapperColor::PropertyWrapperColor): (WebCore::PropertyWrapperColor::value const): (WebCore::PropertyWrapperVisitedAffectedStyleColor::PropertyWrapperVisitedAffectedStyleColor): (WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor): (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): (WebCore::PropertyWrapperColor::unresolvedValue const): Deleted. Canonical link: https://commits.webkit.org/262822@main
webkit-commit-queue
force-pushed
the
eng/Avoid-unnecessary-StyleColor-copying-in-animation-wrappers
branch
from
601bc42
to
7baa7bf
Compare
|
Committed 262822@main (7baa7bf): https://commits.webkit.org/262822@main Reviewed commits have been landed. Closing PR #12609 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7baa7bf
601bc42
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 mac-AS-debug-wk2