Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary StyleColor copying in animation wrappers #12609

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Avoid unnecessary StyleColor copying in animation wrappers #12609

merged 1 commit into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. Avoid unnecessary StyleColor copying in animation wrappers 

    https://bugs.webkit.org/show_bug.cgi?id=255278
rdar://107875297

Reviewed by Antoine Quint.

There is some unnecessary copying of this not-quite-trivial type.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperStyleColor::PropertyWrapperStyleColor):
(WebCore::PropertyWrapperStyleColor::value const):

Remove templating and have separate classes for StyleColor and Color cases.

(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::value const):
(WebCore::PropertyWrapperVisitedAffectedStyleColor::PropertyWrapperVisitedAffectedStyleColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::PropertyWrapperColor::unresolvedValue const): Deleted.

Canonical link: https://commits.webkit.org/262822@main
    @anttijk
    anttijk committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7baa7bf View commit details
    Browse the repository at this point in the history