Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink size of LiteralParserToken from 24 bytes from 16 bytes. #13249

Merged
merged 1 commit into from Apr 28, 2023
Merged

Shrink size of LiteralParserToken from 24 bytes from 16 bytes. #13249

merged 1 commit into from Apr 28, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 27, 2023 •
edited by webkit-early-warning-system

1f5d2a1

Shrink size of LiteralParserToken from 24 bytes from 16 bytes.
https://bugs.webkit.org/show_bug.cgi?id=256057

Reviewed by Geoffrey Garen.

Shrink size of LiteralParserToken from 24 bytes from 16 bytes, by re-ordering
data members for better bit packing.

* Source/JavaScriptCore/runtime/LiteralParser.h:

Canonical link: https://commits.webkit.org/263477@main

bbb971a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@cdumez cdumez requested a review from a team as a code owner April 27, 2023 21:45
@cdumez cdumez self-assigned this Apr 27, 2023
@cdumez cdumez added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash bbb971a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

geoffreygaren
geoffreygaren approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 27, 2023
@cdumez
Shrink size of LiteralParserToken from 24 bytes from 16 bytes.
1f5d2a1 
https://bugs.webkit.org/show_bug.cgi?id=256057

Reviewed by Geoffrey Garen.

Shrink size of LiteralParserToken from 24 bytes from 16 bytes, by re-ordering
data members for better bit packing.

* Source/JavaScriptCore/runtime/LiteralParser.h:

Canonical link: https://commits.webkit.org/263477@main
@webkit-commit-queue webkit-commit-queue force-pushed the 256057_LiteralParserToken_bit_packing branch from bbb971a to 1f5d2a1 Compare April 28, 2023 00:33
@webkit-commit-queue
Copy link
Collaborator

Committed 263477@main (1f5d2a1): https://commits.webkit.org/263477@main

Reviewed commits have been landed. Closing PR #13249 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1f5d2a1 into WebKit:main Apr 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

Assignees

@cdumez cdumez

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @geoffreygaren