Reduce build times by refactoring WebPage.h #13545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinadler
added
the
WebKit Misc.
|
EWS run on previous version of this PR (hash 89eecf3) |
webkit-ews-buildbot
added
the
merging-blocked
darinadler
removed
the
merging-blocked
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
89eecf3
to
dd2a2f7
Compare
|
EWS run on previous version of this PR (hash dd2a2f7) |
webkit-ews-buildbot
added
the
merging-blocked
darinadler
removed
the
merging-blocked
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
dd2a2f7
to
d8b28c1
Compare
|
EWS run on previous version of this PR (hash d8b28c1) |
webkit-ews-buildbot
added
the
merging-blocked
darinadler
removed
the
merging-blocked
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
d8b28c1
to
1b0cf7d
Compare
|
EWS run on previous version of this PR (hash 1b0cf7d) |
webkit-ews-buildbot
added
the
merging-blocked
darinadler
removed
the
merging-blocked
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
1b0cf7d
to
e8126a6
Compare
|
EWS run on previous version of this PR (hash e8126a6) |
webkit-ews-buildbot
added
the
merging-blocked
Ahmad-S792
reviewed
May 20, 2023
darinadler
removed
the
merging-blocked
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
e8126a6
to
72799d3
Compare
|
EWS run on previous version of this PR (hash 72799d3) |
webkit-ews-buildbot
added
the
merging-blocked
darinadler
removed
the
merging-blocked
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
72799d3
to
002d300
Compare
|
EWS run on previous version of this PR (hash 002d300) |
https://bugs.webkit.org/show_bug.cgi?id=256424 rdar://108997618 Reviewed by NOBODY (OOPS!). * Source/JavaScriptCore/inspector/InspectorFrontendChannel.h: Moved FrontendChannel::ConnectionType out to the namespace level so it can be forward declared. * Source/WTF/wtf/RunLoop.cpp: (WTF::runLoopHolder): Made this a non-member function so we don't have to include ThreadSpecific.h in the header. * Source/WebCore/dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Use AllPlugins and OnlyApplicationPlugins. * Source/WebCore/page/MediaControlsContextMenuItem.h: Moved MediaControlsContextMenuItem::ID out to the namespace level so it can be fowrad declared. * Source/WebCore/page/PageOverlay.cpp: (WebCore::generatePageOverlayID): Use PageOverlayID. * Source/WebCore/page/PageOverlay.h: Move PageOverlay::PageOverlayID out to the namespace level so it can be forward declared. * Source/WebCore/page/WebCoreKeyboardUIMode.h: Add an underlying type to KeyboardUIMode so it can be forward declared. * Source/WebCore/plugins/PluginData.cpp: (WebCore::supportsMimeTypeForPlugins): Use AllowedPluginTypes and AllPlugins. * Source/WebCore/plugins/PluginData.h: Moved PluginData::AllowedPluginTypes out to the namespace level so it can be forward declared. * Source/WebKit/Shared/ContentWorldShared.h: Use a struct for the argument to ObjectIdentifier so ContentWorldIdentifier can be forward declared. * Source/WebKit/Shared/WebHitTestResultData.h: Use WebCore::PageOverlayID. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: Updated includes. * Source/WebKit/UIProcess/WebPageProxy.cpp: Ditto. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Added WebPageInternals.h and DrawingAreaInlines.h. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIEventCocoa.mm: Updated includes. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebNavigationEventCocoa.mm: Ditto. * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIEvent.h: Ditto. Ditto. * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebNavigationEvent.h: Ditto. * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: Ditto. * Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: Ditto. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Ditto. * Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Ditto. * Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h: Ditto. * Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.h: Ditto. * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::webResourceLoaderForIdentifier const): Moved here from header. (WebKit::WebLoaderStrategy::ongoingLoads const): Ditto. * Source/WebKit/WebProcess/Network/WebLoaderStrategy.h: Updated for the above. * Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp: (WebKit::WebAuthenticatorCoordinator::processingUserGesture): Pass nullopt for the ResourceLoaderIdentifier for addConsoleMessage. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: Updated includes. * Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h: Ditto. * Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp: Ditto. * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Updated includes. (WebKit::WebFrameLoaderClient::objectContentType): Use AllPlugins and OnlyApplicationPlugins. * Source/WebKit/WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Updated includes. * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: Updated includes. (WebKit::OverridePasteboardForSelectionReplacement::OverridePasteboardForSelectionReplacement): Use Span instead of IPC::DataReference. (WebKit::WebPage::replaceImageForRemoveBackground): Ditto. (WebKit::WebPage::replaceSelectionWithPasteboardData): Ditto. (WebKit::WebPage::sanitizeLookalikeCharacters): Moved non-Apple-internal version to WebPage.cpp. (WebKit::WebPage::allowedLookalikeCharacters): Ditto. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp: Updated includes. * Source/WebKit/WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::displayColorSpace const): Moved here from header. (WebKit::DrawingArea::activityStateDidChange): Ditto. (WebKit::DrawingArea::setColorSpace): Ditto. (WebKit::DrawingArea::acceleratedAnimationDidStart): Ditto. (WebKit::DrawingArea::acceleratedAnimationDidEnd): Ditto. (WebKit::DrawingArea::adjustTransientZoom): Ditto. (WebKit::DrawingArea::commitTransientZoom): Ditto. (WebKit::DrawingArea::addRootFrame): Ditto. (WebKit::DrawingArea::mainFrameContentSizeChanged): Ditto. (WebKit::DrawingArea::attachViewOverlayGraphicsLayer): Ditto. * Source/WebKit/WebProcess/WebPage/DrawingArea.h: Reduced includes, added forward declarations, moved functions out of the header that can't compile without the includes. These were virtual functions and not inlined in practice anyway except for send, which is moved into DrawingAreaInlines.h. * Source/WebKit/WebProcess/WebPage/DrawingAreaInlines.h: Added. * Source/WebKit/WebProcess/WebPage/EventDispatcher.h: Moved EventDispatcher::WheelEventOrigin out to the namespace level so it can be forward declared. * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h: Updated includes. * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: Ditto. * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: Ditto. * Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp: Ditto. * Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.h: Moved WebBackForwardListProxy::OverwriteExistingItem out to the namespace level so it cna be forward declared. * Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp: Updated includes. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: Updated includes. (WebKit::WebPage::Internals::Internals): Added. (WebKit::overriddenMediaType): Updated to use internals(). (WebKit::WebPage::WebPage): Ditto. (WebKit::m_appHighlightsVisible): Ditto. (WebKit::WebPage::reinitializeWebPage): Ditto. (WebKit::WebPage::updateThrottleState): Ditto. (WebKit::WebPage::isThrottleable const): Ditto. (WebKit::WebPage::initializeInjectedBundleFullScreenClient): Ditto. (WebKit::WebPage::editorState const): Ditto. (WebKit::WebPage::close): Ditto. (WebKit::WebPage::loadDataInFrame): Ditto. (WebKit::WebPage::loadRequest): Ditto. (WebKit::WebPage::loadDataImpl): Ditto. (WebKit::WebPage::loadAlternateHTML): Ditto. (WebKit::WebPage::loadSimulatedRequestAndResponse): Ditto. (WebKit::WebPage::goToBackForwardItem): Ditto. (WebKit::WebPage::setSize): Ditto. (WebKit::WebPage::sendViewportAttributesChanged): Ditto. (WebKit::WebPage::scalePage): Ditto. (WebKit::WebPage::setFixedLayoutSize): Ditto. (WebKit::WebPage::setDefaultUnobscuredSize): Ditto. (WebKit::WebPage::updateSizeForCSSDefaultViewportUnits): Ditto. (WebKit::WebPage::setMinimumUnobscuredSize): Ditto. (WebKit::WebPage::updateSizeForCSSSmallViewportUnits): Ditto. (WebKit::WebPage::setMaximumUnobscuredSize): Ditto. (WebKit::WebPage::updateSizeForCSSLargeViewportUnits): Ditto. (WebKit::WebPage::disabledAdaptationsDidChange): Ditto. (WebKit::WebPage::viewportPropertiesDidChange): Ditto. (WebKit::WebPage::pageDidScroll): Ditto. (WebKit::WebPage::freezeLayerTree): Ditto. (WebKit::WebPage::unfreezeLayerTree): Ditto. (WebKit::WebPage::isLayerTreeFrozen): Ditto. (WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState): Ditto. (WebKit::WebPage::markLayersVolatile): Ditto. (WebKit::WebPage::tryMarkLayersVolatileCompletionHandler): Ditto. (WebKit::WebPage::cancelMarkLayersVolatile): Ditto. (WebKit::WebPage::contextMenuForKeyEvent): Ditto. (WebKit::WebPage::mouseEvent): Ditto. (WebKit::WebPage::handleWheelEvent): Ditto. (WebKit::WebPage::wheelEvent): Ditto. (WebKit::WebPage::keyEvent): Ditto. (WebKit::WebPage::restoreSessionInternal): Ditto. (WebKit::WebPage::restoreSession): Ditto. (WebKit::WebPage::updateBackForwardListForReattach): Ditto. (WebKit::WebPage::setCurrentHistoryItemForReattach): Ditto. (WebKit::WebPage::cancelCurrentInteractionInformationRequest): Ditto. (WebKit::WebPage::dispatchTouchEvent): Ditto. (WebKit::WebPage::setBackgroundColor): Ditto. (WebKit::WebPage::updateIsInWindow): Ditto. (WebKit::WebPage::visibilityDidChange): Ditto. (WebKit::WebPage::setActivityState): Ditto. (WebKit::WebPage::runJavaScript): Ditto. (WebKit::WebPage::runJavaScriptInFrameInScriptWorld): Ditto. (WebKit::WebPage::willCommitLayerTree): Ditto. (WebKit::WebPage::didFlushLayerTreeAtTime): Ditto. (WebKit::WebPage::performDragControllerAction): Ditto. (WebKit::WebPage::webUndoStep): Ditto. (WebKit::WebPage::addWebUndoStep): Ditto. (WebKit::WebPage::removeWebEditCommand): Ditto. (WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon): Ditto. (WebKit::WebPage::updateMainFrameScrollOffsetPinning): Ditto. (WebKit::WebPage::mainFrameDidLayout): Ditto. (WebKit::WebPage::windowAndViewFramesChanged): Ditto. (WebKit::WebPage::addResourceRequest): Ditto. (WebKit::WebPage::removeResourceRequest): Ditto. (WebKit::WebPage::setMayStartMediaWhenInWindow): Ditto. (WebKit::WebPage::elementDidFocus): Ditto. (WebKit::WebPage::setMinimumSizeForAutoLayout): Ditto. (WebKit::WebPage::setSizeToContentAutoSizeMaximumSize): Ditto. (WebKit::WebPage::setAutoSizingShouldExpandToViewHeight): Ditto. (WebKit::WebPage::setViewportSizeForCSSViewportUnits): Ditto. (WebKit::WebPage::canShowMIMEType const): Ditto. (WebKit::WebPage::addTextCheckingRequest): Ditto. (WebKit::WebPage::didFinishCheckingText): Ditto. (WebKit::WebPage::didCancelCheckingText): Ditto. (WebKit::WebPage::willReplaceMultipartContent): Ditto. (WebKit::WebPage::didReplaceMultipartContent): Ditto. (WebKit::WebPage::didCommitLoad): Ditto. (WebKit::WebPage::updateWebsitePolicies): Ditto. (WebKit::WebPage::createDocumentLoader): Ditto. (WebKit::WebPage::updateIntrinsicContentSizeIfNeeded): Ditto. (WebKit::WebPage::flushPendingIntrinsicContentSizeUpdate): Ditto. (WebKit::WebPage::scheduleIntrinsicContentSizeUpdate): Ditto. (WebKit::WebPage::registerURLSchemeHandler): Ditto. (WebKit::WebPage::urlSchemeTaskWillPerformRedirection): Ditto. (WebKit::WebPage::urlSchemeTaskDidPerformRedirection): Ditto. (WebKit::WebPage::urlSchemeTaskDidReceiveResponse): Ditto. (WebKit::WebPage::urlSchemeTaskDidReceiveData): Ditto. (WebKit::WebPage::urlSchemeTaskDidComplete): Ditto. (WebKit::WebPage::hasStorageAccess): Ditto. (WebKit::WebPage::requestStorageAccess): Ditto. (WebKit::WebPage::addDomainWithPageLevelStorageAccess): Ditto. (WebKit::WebPage::hasPageLevelStorageAccess const): Ditto. (WebKit::WebPage::clearPageLevelStorageAccess): Ditto. (WebKit::WebPage::didLoadFromRegistrableDomain): Ditto. (WebKit::WebPage::getLoadedSubresourceDomains): Ditto. (WebKit::WebPage::clearLoadedSubresourceDomains): Ditto. (WebKit::WebPage::elementForContext const): Ditto. (WebKit::WebPage::contextForElement const): Ditto. (WebKit::WebPage::startTextManipulations): Ditto. (WebKit::WebPage::startTextManipulationForFrame): Ditto. (WebKit::WebPage::textAutosizingUsesIdempotentModeChanged): Ditto. (WebKit::WebPage::synchronizeCORSDisablingPatternsWithNetworkProcess): Ditto. (WebKit::WebPage::createAppHighlightInSelectedRange): Ditto. (WebKit::WebPage::shouldAllowRemoveBackground const): Ditto. (WebKit::WebPage::setIsWindowResizingEnabled): Ditto. (WebKit::WebPage::setLookalikeCharacterStrings): Ditto. (WebKit::WebPage::setAllowedLookalikeCharacterStrings): Ditto. (WebKit::WebPage::injectedBundleFullScreenClient): Added. (WebKit::WebPage::beginPrintingDuringDOMPrintOperation): Added. (WebKit::WebPage::drawPagesToPDFDuringDOMPrintOperation): Added. (WebKit::WebPage::drawRectToImageDuringDOMPrintOperation): Added. (WebKit::WebPage::computePagesForPrintingDuringDOMPrintOperation): Added. (WebKit::WebPage::drawPagesForPrintingDuringDOMPrintOperation): Added. (WebKit::WebPage::identifier const): Added. (WebKit::WebPage::activityState const): Added. (WebKit::WebPage::underlayColor const): Added. (WebKit::WebPage::setUnderlayColor): Added. (WebKit::WebPage::backgroundColor const): Added. (WebKit::WebPage::highlightIsNewGroup const): Added. (WebKit::WebPage::accessibilityPosition const): Added. (WebKit::WebPage::webPageProxyIdentifier const): Added. (WebKit::WebPage::allowedDragSourceActions const): Added. (WebKit::WebPage::loadedSubresourceDomains const): Added. (WebKit::WebPage::minimumSizeForAutoLayout const): Added. (WebKit::WebPage::highlightRequestOriginatedInApp const): Added. (WebKit::WebPage::viewportSizeForCSSViewportUnits const): Added. (WebKit::WebPage::sizeToContentAutoSizeMaximumSize const): Added. (WebKit::WebPage::windowFrameInUnflippedScreenCoordinates const): Added. (WebKit::WebPage::size const): Added. (WebKit::WebPage::sessionStorageNamespaceIdentifier const): Added. (WebKit::WebPage::isVisible const): Added. (WebKit::WebPage::isVisibleOrOccluded const): Added. (WebKit::WebPage::viewportConfiguration const): Added. (WebKit::WebPage::hostFileDescriptor const): Added. (WebKit::WebPage::sanitizeLookalikeCharacters): Added. (WebKit::WebPage::allowedLookalikeCharacters): Added. * Source/WebKit/WebProcess/WebPage/WebPage.h: Removed most includes. Added forward declarations. Moved things that required the includes into WebPageInternals.h, WebPageInlines.h, and WebPage.cpp. * Source/WebKit/WebProcess/WebPage/WebPageInlines.h: Moved userContentControllerIdentifier and sendSyncWithDelayedReply here. Moved sessionStorageNamespaceIdentifier, isVisible, and isVisibleOrOccluded into WebPage.cpp. * Source/WebKit/WebProcess/WebPage/WebPageInternals.h: Added. * Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp: (WebKit::inputMethodState): Renamed. (WebKit::WebPage::setInputMethodState): Use internals(). (WebKit::WebPage::sendMessageToWebProcessExtensionWithReply): Ditto. * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::screenSize const): Use internals(). (WebKit::WebPage::availableScreenSize const): Ditto. (WebKit::WebPage::overrideScreenSize const): Ditto. (WebKit::WebPage::savePageState): Ditto. (WebKit::WebPage::restorePageState): Ditto. (WebKit::WebPage::minimumPageScaleFactor const): Ditto. (WebKit::WebPage::maximumPageScaleFactor const): Ditto. (WebKit::WebPage::maximumPageScaleFactorIgnoringAlwaysScalable const): Ditto. (WebKit::WebPage::allowsUserScaling const): Ditto. (WebKit::WebPage::handleEditingKeyboardEvent): Ditto. (WebKit::WebPage::registerUIProcessAccessibilityTokens): Ditto. (WebKit::WebPage::rectForElementAtInteractionLocation const): Ditto. (WebKit::WebPage::handleSyntheticClick): Ditto. (WebKit::WebPage::didFinishContentChangeObserving): Ditto. (WebKit::WebPage::completeSyntheticClick): Ditto. (WebKit::WebPage::attemptSyntheticClick): Ditto. (WebKit::WebPage::requestDragStart): Ditto. (WebKit::WebPage::requestAdditionalItemsForDragSession): Ditto. (WebKit::WebPage::didConcludeDrop): Ditto. (WebKit::WebPage::didConcludeEditDrag): Ditto. (WebKit::WebPage::didFinishLoadingImageForElement): Ditto. (WebKit::WebPage::computeAndSendEditDragSnapshot): Ditto. (WebKit::WebPage::handleTwoFingerTapAtPoint): Ditto. (WebKit::WebPage::potentialTapAtPosition): Ditto. (WebKit::WebPage::commitPotentialTap): Ditto. (WebKit::WebPage::commitPotentialTapFailed): Ditto. (WebKit::WebPage::cancelPotentialTapInFrame): Ditto. (WebKit::WebPage::setForceAlwaysUserScalable): Ditto. (WebKit::WebPage::selectWithGesture): Ditto. (WebKit::WebPage::clearSelection): Ditto. (WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Ditto. (WebKit::WebPage::storeSelectionForAccessibility): Ditto. (WebKit::WebPage::getRectsAtSelectionOffsetWithText): Ditto. (WebKit::WebPage::setSelectionRange): Ditto. (WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto. (WebKit::WebPage::focusedElementInformation): Ditto. (WebKit::WebPage::setViewportConfigurationViewLayoutSize): Ditto. (WebKit::WebPage::dynamicViewportSizeUpdate): Ditto. (WebKit::WebPage::resetViewportDefaultConfiguration): Ditto. (WebKit::WebPage::resetIdempotentTextAutosizingIfNeeded): Ditto. (WebKit::WebPage::shrinkToFitContent): Ditto. (WebKit::WebPage::viewportConfigurationChanged): Ditto. (WebKit::WebPage::applicationDidFinishSnapshottingAfterEnteringBackground): Ditto. (WebKit::WebPage::scaleFromUIProcess const): Ditto. (WebKit::WebPage::updateVisibleContentRects): Ditto. (WebKit::WebPage::textInputContextsInRect): Ditto. (WebKit::WebPage::platformDidScalePage): Ditto. * Source/WebKit/WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.cpp: Updated includes. * Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Updated includes. * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::executeKeypressCommandsInternal): Use internals(). (WebKit::WebPage::registerUIProcessAccessibilityTokens): Ditto. (WebKit::WebPage::zoomPDFIn): Ditto. (WebKit::WebPage::zoomPDFOut): Ditto. (WebKit::WebPage::savePDF): Ditto. (WebKit::WebPage::openPDFWithPreview): Ditto. (WebKit::WebPage::createPDFHUD): Ditto. (WebKit::WebPage::updatePDFHUDLocation): Ditto. (WebKit::WebPage::removePDFHUD): Ditto. * Source/WebKit/WebProcess/WebProcess.cpp: Updated includes. * Source/WebKit/WebProcess/WebStorage/StorageNamespaceIdentifier.h: Use struct for StorageNamespaceIdentifierType so it can be forward declared. * Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm: Updated includes. * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): Use WebCore::AllPlugins and WebCore::OnlyApplicationPlugins.
darinadler
force-pushed
the
eng/Reduce-build-times-by-refactoring-WebPage-h
branch
from
002d300
to
2aea878
Compare
darinadler
requested review from
a team,
donny-dont,
zdobersek,
magomez,
b-weinstein,
xeenon,
cdumez,
rniwa and
patrickangle
as code owners
|
EWS run on current version of this PR (hash 2aea878) |
webkit-ews-buildbot
added
the
merging-blocked
brentfulgham
approved these changes
Jun 2, 2023
| @@ -31,7 +31,6 @@ | |||
| #include "JSWebExtensionWrappable.h" | |||
| #include "WebExtensionAPIObject.h" | |||
| #include "WebExtensionEventListenerType.h" | |||
| #include "WebPage.h" | |||
|
|
||
| namespace WTF { | ||
| class MachSendRight; | ||
| } |
There was a problem hiding this comment.
This is a significant cleanup!
The API test failure looks like it could be real: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3230 Value of: [innerText isEqualToString:@"Print"] Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3239 Value of: [innerText isEqualToString:@"Print"] |
Yes, I haven’t figured out what caused the failure and won’t land until I do. I wish the test wrote out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2aea878
2aea878