-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SubframePageProxy to RemotePageProxy #14831
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/Rename-SubframePageProxy-to-RemotePageProxy
Jun 9, 2023
Merged
Rename SubframePageProxy to RemotePageProxy #14831
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/Rename-SubframePageProxy-to-RemotePageProxy
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebKit Process Model
Bugs related to WebKit's multi-process architecture
label
Jun 9, 2023
EWS run on current version of this PR (hash 6a90852) |
pascoej
approved these changes
Jun 9, 2023
achristensen07
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Jun 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=257916 rdar://110550953 Reviewed by J Pascoe. A RemotePageProxy is the UI process object paired with a WebPage with a RemoteFrame as its main frame. It has been only used for pages with local subframes, so I initially called it SubframePageProxy because it communicates with the processes containing subframes. However, with site isolated pages from window.open, the name no longer reflects how it will be used. This rename does not change any behavior. * Source/WebKit/Sources.txt: * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: * Source/WebKit/UIProcess/RemotePageProxy.cpp: Renamed from Source/WebKit/UIProcess/SubframePageProxy.cpp. (WebKit::RemotePageProxy::RemotePageProxy): (WebKit::RemotePageProxy::~RemotePageProxy): (WebKit::RemotePageProxy::messageSenderConnection const): (WebKit::RemotePageProxy::messageSenderDestinationID const): (WebKit::RemotePageProxy::didReceiveMessage): (WebKit::RemotePageProxy::decidePolicyForResponse): (WebKit::RemotePageProxy::didCommitLoadForFrame): (WebKit::RemotePageProxy::didReceiveSyncMessage): * Source/WebKit/UIProcess/RemotePageProxy.h: Renamed from Source/WebKit/UIProcess/SubframePageProxy.h. (WebKit::RemotePageProxy::create): (WebKit::RemotePageProxy::process): * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::commitProvisionalFrame): (WebKit::WebFrameProxy::setRemotePageProxy): (WebKit::WebFrameProxy::setSubframePageProxy): Deleted. * Source/WebKit/UIProcess/WebFrameProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getAllFrameTrees): (WebKit::WebPageProxy::updateRemoteFrameSize): (WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::callAfterNextPresentationUpdate): (WebKit::WebPageProxy::addRemotePageProxy): (WebKit::WebPageProxy::removeRemotePageProxy): (WebKit::WebPageProxy::remotePageProxyForRegistrableDomain const): (WebKit::WebPageProxy::addSubframePageProxy): Deleted. (WebKit::WebPageProxy::removeSubpageFrameProxy): Deleted. (WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/265041@main
webkit-commit-queue
force-pushed
the
eng/Rename-SubframePageProxy-to-RemotePageProxy
branch
from
June 9, 2023 23:20
6a90852
to
43f29b7
Compare
Committed 265041@main (43f29b7): https://commits.webkit.org/265041@main Reviewed commits have been landed. Closing PR #14831 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
43f29b7
6a90852
π wincairoπ§ͺ api-macπ§ͺ gtk-wk2π§ͺ mac-AS-debug-wk2π tv-simπ watch