Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SubframePageProxy to RemotePageProxy #14831

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Jun 9, 2023

43f29b7

Rename SubframePageProxy to RemotePageProxy
https://bugs.webkit.org/show_bug.cgi?id=257916
rdar://110550953

Reviewed by J Pascoe.

A RemotePageProxy is the UI process object paired with a WebPage with a RemoteFrame as its main frame.
It has been only used for pages with local subframes, so I initially called it SubframePageProxy because
it communicates with the processes containing subframes.  However, with site isolated pages from window.open,
the name no longer reflects how it will be used.  This rename does not change any behavior.

* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
* Source/WebKit/UIProcess/RemotePageProxy.cpp: Renamed from Source/WebKit/UIProcess/SubframePageProxy.cpp.
(WebKit::RemotePageProxy::RemotePageProxy):
(WebKit::RemotePageProxy::~RemotePageProxy):
(WebKit::RemotePageProxy::messageSenderConnection const):
(WebKit::RemotePageProxy::messageSenderDestinationID const):
(WebKit::RemotePageProxy::didReceiveMessage):
(WebKit::RemotePageProxy::decidePolicyForResponse):
(WebKit::RemotePageProxy::didCommitLoadForFrame):
(WebKit::RemotePageProxy::didReceiveSyncMessage):
* Source/WebKit/UIProcess/RemotePageProxy.h: Renamed from Source/WebKit/UIProcess/SubframePageProxy.h.
(WebKit::RemotePageProxy::create):
(WebKit::RemotePageProxy::process):
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::commitProvisionalFrame):
(WebKit::WebFrameProxy::setRemotePageProxy):
(WebKit::WebFrameProxy::setSubframePageProxy): Deleted.
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getAllFrameTrees):
(WebKit::WebPageProxy::updateRemoteFrameSize):
(WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
(WebKit::WebPageProxy::addRemotePageProxy):
(WebKit::WebPageProxy::removeRemotePageProxy):
(WebKit::WebPageProxy::remotePageProxyForRegistrableDomain const):
(WebKit::WebPageProxy::addSubframePageProxy): Deleted.
(WebKit::WebPageProxy::removeSubpageFrameProxy): Deleted.
(WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265041@main

6a90852

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
  πŸ›  tv-sim
  πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@achristensen07 achristensen07 self-assigned this Jun 9, 2023
@achristensen07 achristensen07 added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Jun 9, 2023
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=257916
rdar://110550953

Reviewed by J Pascoe.

A RemotePageProxy is the UI process object paired with a WebPage with a RemoteFrame as its main frame.
It has been only used for pages with local subframes, so I initially called it SubframePageProxy because
it communicates with the processes containing subframes.  However, with site isolated pages from window.open,
the name no longer reflects how it will be used.  This rename does not change any behavior.

* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
* Source/WebKit/UIProcess/RemotePageProxy.cpp: Renamed from Source/WebKit/UIProcess/SubframePageProxy.cpp.
(WebKit::RemotePageProxy::RemotePageProxy):
(WebKit::RemotePageProxy::~RemotePageProxy):
(WebKit::RemotePageProxy::messageSenderConnection const):
(WebKit::RemotePageProxy::messageSenderDestinationID const):
(WebKit::RemotePageProxy::didReceiveMessage):
(WebKit::RemotePageProxy::decidePolicyForResponse):
(WebKit::RemotePageProxy::didCommitLoadForFrame):
(WebKit::RemotePageProxy::didReceiveSyncMessage):
* Source/WebKit/UIProcess/RemotePageProxy.h: Renamed from Source/WebKit/UIProcess/SubframePageProxy.h.
(WebKit::RemotePageProxy::create):
(WebKit::RemotePageProxy::process):
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::commitProvisionalFrame):
(WebKit::WebFrameProxy::setRemotePageProxy):
(WebKit::WebFrameProxy::setSubframePageProxy): Deleted.
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getAllFrameTrees):
(WebKit::WebPageProxy::updateRemoteFrameSize):
(WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
(WebKit::WebPageProxy::addRemotePageProxy):
(WebKit::WebPageProxy::removeRemotePageProxy):
(WebKit::WebPageProxy::remotePageProxyForRegistrableDomain const):
(WebKit::WebPageProxy::addSubframePageProxy): Deleted.
(WebKit::WebPageProxy::removeSubpageFrameProxy): Deleted.
(WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265041@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Rename-SubframePageProxy-to-RemotePageProxy branch from 6a90852 to 43f29b7 Compare June 9, 2023 23:20
@webkit-commit-queue
Copy link
Collaborator

Committed 265041@main (43f29b7): https://commits.webkit.org/265041@main

Reviewed commits have been landed. Closing PR #14831 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 43f29b7 into WebKit:main Jun 9, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
4 participants