Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SubframePageProxy to RemotePageProxy #14831

Commits on Jun 9, 2023

  1. Rename SubframePageProxy to RemotePageProxy

    https://bugs.webkit.org/show_bug.cgi?id=257916
    rdar://110550953
    
    Reviewed by J Pascoe.
    
    A RemotePageProxy is the UI process object paired with a WebPage with a RemoteFrame as its main frame.
    It has been only used for pages with local subframes, so I initially called it SubframePageProxy because
    it communicates with the processes containing subframes.  However, with site isolated pages from window.open,
    the name no longer reflects how it will be used.  This rename does not change any behavior.
    
    * Source/WebKit/Sources.txt:
    * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
    * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
    * Source/WebKit/UIProcess/RemotePageProxy.cpp: Renamed from Source/WebKit/UIProcess/SubframePageProxy.cpp.
    (WebKit::RemotePageProxy::RemotePageProxy):
    (WebKit::RemotePageProxy::~RemotePageProxy):
    (WebKit::RemotePageProxy::messageSenderConnection const):
    (WebKit::RemotePageProxy::messageSenderDestinationID const):
    (WebKit::RemotePageProxy::didReceiveMessage):
    (WebKit::RemotePageProxy::decidePolicyForResponse):
    (WebKit::RemotePageProxy::didCommitLoadForFrame):
    (WebKit::RemotePageProxy::didReceiveSyncMessage):
    * Source/WebKit/UIProcess/RemotePageProxy.h: Renamed from Source/WebKit/UIProcess/SubframePageProxy.h.
    (WebKit::RemotePageProxy::create):
    (WebKit::RemotePageProxy::process):
    * Source/WebKit/UIProcess/WebFrameProxy.cpp:
    (WebKit::WebFrameProxy::commitProvisionalFrame):
    (WebKit::WebFrameProxy::setRemotePageProxy):
    (WebKit::WebFrameProxy::setSubframePageProxy): Deleted.
    * Source/WebKit/UIProcess/WebFrameProxy.h:
    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::getAllFrameTrees):
    (WebKit::WebPageProxy::updateRemoteFrameSize):
    (WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses):
    (WebKit::WebPageProxy::didFinishLoadForFrame):
    (WebKit::WebPageProxy::callAfterNextPresentationUpdate):
    (WebKit::WebPageProxy::addRemotePageProxy):
    (WebKit::WebPageProxy::removeRemotePageProxy):
    (WebKit::WebPageProxy::remotePageProxyForRegistrableDomain const):
    (WebKit::WebPageProxy::addSubframePageProxy): Deleted.
    (WebKit::WebPageProxy::removeSubpageFrameProxy): Deleted.
    (WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const): Deleted.
    * Source/WebKit/UIProcess/WebPageProxy.h:
    * Source/WebKit/UIProcess/WebPageProxyInternals.h:
    * Source/WebKit/UIProcess/WebProcessPool.cpp:
    (WebKit::WebProcessPool::processForNavigation):
    * Source/WebKit/WebKit.xcodeproj/project.pbxproj:
    
    Canonical link: https://commits.webkit.org/265041@main
    achristensen07 committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    43f29b7 View commit details
    Browse the repository at this point in the history