Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce repetitive logging in B3 disassembly #15114

Conversation

ddegazio
Copy link
Contributor

@ddegazio ddegazio commented Jun 20, 2023

0449dbc

Reduce repetitive logging in B3 disassembly
https://bugs.webkit.org/show_bug.cgi?id=258317
rdar://111057998

Reviewed by Yusuke Suzuki.

When logging B3 disassembly, adds a check to see if the last Air
instruction had the same origin. If it did, we skip logging it
again, to reduce clutter when a B3 value lowers to multiple
consecutive Air instructions.

* Source/JavaScriptCore/ftl/FTLState.cpp:
(JSC::FTL::State::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:
(JSC::Wasm::OSREntryPlan::dumpDisassembly):

Canonical link: https://commits.webkit.org/265338@main

292133e

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@ddegazio ddegazio requested a review from a team as a code owner June 20, 2023 19:58
@ddegazio ddegazio self-assigned this Jun 20, 2023
@ddegazio ddegazio added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 20, 2023
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@ddegazio ddegazio added the merge-queue Applied to send a pull request to merge-queue label Jun 20, 2023
https://bugs.webkit.org/show_bug.cgi?id=258317
rdar://111057998

Reviewed by Yusuke Suzuki.

When logging B3 disassembly, adds a check to see if the last Air
instruction had the same origin. If it did, we skip logging it
again, to reduce clutter when a B3 value lowers to multiple
consecutive Air instructions.

* Source/JavaScriptCore/ftl/FTLState.cpp:
(JSC::FTL::State::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:
(JSC::Wasm::OSREntryPlan::dumpDisassembly):

Canonical link: https://commits.webkit.org/265338@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Reduce-repetitive-logging-in-B3-disassembly branch from 292133e to 0449dbc Compare June 20, 2023 22:37
@webkit-commit-queue
Copy link
Collaborator

Committed 265338@main (0449dbc): https://commits.webkit.org/265338@main

Reviewed commits have been landed. Closing PR #15114 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0449dbc into WebKit:main Jun 20, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
4 participants