Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce repetitive logging in B3 disassembly #15114

Commits on Jun 20, 2023

  1. Reduce repetitive logging in B3 disassembly

    https://bugs.webkit.org/show_bug.cgi?id=258317
    rdar://111057998
    
    Reviewed by Yusuke Suzuki.
    
    When logging B3 disassembly, adds a check to see if the last Air
    instruction had the same origin. If it did, we skip logging it
    again, to reduce clutter when a B3 value lowers to multiple
    consecutive Air instructions.
    
    * Source/JavaScriptCore/ftl/FTLState.cpp:
    (JSC::FTL::State::dumpDisassembly):
    * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
    (JSC::Wasm::BBQPlan::dumpDisassembly):
    * Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
    (JSC::Wasm::OMGPlan::dumpDisassembly):
    * Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:
    (JSC::Wasm::OSREntryPlan::dumpDisassembly):
    
    Canonical link: https://commits.webkit.org/265338@main
    ddegazio committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0449dbc View commit details
    Browse the repository at this point in the history