Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal #15234

Merged
merged 1 commit into from Jun 23, 2023
Merged

[css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal #15234

merged 1 commit into from Jun 23, 2023

Conversation

vitorroriz
Copy link
Contributor

@vitorroriz vitorroriz commented Jun 23, 2023 •
edited by webkit-early-warning-system

e01c725

[css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal
https://bugs.webkit.org/show_bug.cgi?id=258447
rdar://111208503

Reviewed by Tim Nguyen.

cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal
according to CSSWG resolution: w3c/csswg-drafts#8975

* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt:
* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205.html:
* Source/WebCore/css/counterStyles.css:
(@counter-style cjk-earthly-branch):
(@counter-style cjk-heavenly-stem):

Canonical link: https://commits.webkit.org/265474@main

b60885b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
loading 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
  🛠 watch-sim

@vitorroriz vitorroriz self-assigned this Jun 23, 2023
@vitorroriz vitorroriz added the CSS Cascading Style Sheets implementation label Jun 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash bec4dc5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz requested a review from nt1m June 23, 2023 10:26
@vitorroriz vitorroriz force-pushed the eng/css-counter-styles-3-cjk-earthly-branch-and-cjk-heavenly-stem-should-fallback-to-cjk-decimal branch from bec4dc5 to 1238696 Compare June 23, 2023 11:43
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 1238696)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 23, 2023
@vitorroriz vitorroriz removed the merging-blocked Applied to prevent a change from being merged label Jun 23, 2023
@vitorroriz vitorroriz force-pushed the eng/css-counter-styles-3-cjk-earthly-branch-and-cjk-heavenly-stem-should-fallback-to-cjk-decimal branch from 1238696 to d57c90a Compare June 23, 2023 13:21
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash d57c90a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz force-pushed the eng/css-counter-styles-3-cjk-earthly-branch-and-cjk-heavenly-stem-should-fallback-to-cjk-decimal branch from d57c90a to b60885b Compare June 23, 2023 18:49
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b60885b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
loading 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
  🛠 watch-sim

@vitorroriz vitorroriz added the merge-queue Applied to send a pull request to merge-queue label Jun 23, 2023
@vitorroriz
[css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem shoul…
e01c725 
…d fallback to cjk-decimal

https://bugs.webkit.org/show_bug.cgi?id=258447
rdar://111208503

Reviewed by Tim Nguyen.

cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal
according to CSSWG resolution: w3c/csswg-drafts#8975

* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt:
* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205.html:
* Source/WebCore/css/counterStyles.css:
(@counter-style cjk-earthly-branch):
(@counter-style cjk-heavenly-stem):

Canonical link: https://commits.webkit.org/265474@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/css-counter-styles-3-cjk-earthly-branch-and-cjk-heavenly-stem-should-fallback-to-cjk-decimal branch from b60885b to e01c725 Compare June 23, 2023 19:52
@webkit-commit-queue
Copy link
Collaborator

Committed 265474@main (e01c725): https://commits.webkit.org/265474@main

Reviewed commits have been landed. Closing PR #15234 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 23, 2023
@webkit-commit-queue webkit-commit-queue merged commit e01c725 into WebKit:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@vitorroriz vitorroriz

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@vitorroriz @webkit-early-warning-system @webkit-commit-queue @nt1m @webkit-ews-buildbot