Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-counter-styles-3] fallback for cjk-earthly-branch and cjk-heavenly-stem #8975

Closed
vitorroriz opened this issue Jun 16, 2023 · 4 comments
Closed

[css-counter-styles-3] fallback for cjk-earthly-branch and cjk-heavenly-stem #8975

vitorroriz opened this issue Jun 16, 2023 · 4 comments
Labels
Closed Accepted by CSSWG Resolution css-counter-styles-3 Current Work i18n-clreq Chinese language enablement i18n-jlreq Japanese language enablement i18n-klreq Korean language enablement i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response.

Comments

@vitorroriz
Copy link

vitorroriz commented Jun 16, 2023 •
edited

As it is being discussed in #8596, it seems the right system for these styles is fixed. With that, the fallback for them becomes more relevant, given they defined just a few symbols (10 and 12). The styles don't explicitly define a fallback, so it is decimal.

I have no knowledge on CJK languages, but I'm wondering if decimal is the best fallback for them. For example, other CJK related styles have cjk-decimal as fallback. So I'd like to discuss if this (or another style) would be a better fallback option here.
@vitorroriz vitorroriz mentioned this issue Jun 16, 2023
Closed
@nt1m nt1m added the Agenda+ label Jun 16, 2023
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-counter-styles-3] fallback for cjk-earthly-branch and cjk-heavenly-stem, and agreed to the following:

  • RESOLVED: Change fallback for cjk-earthly-branch and cjk-heavenly-stem to cjk-decimal instead of decimal
  • RESOLVED: Republish CR
The full IRC log of that discussion <TabAtkins> seems reasonable to me too
<emilio> fantasai: seems reasonable, we should make the change and republish
<emilio> miriam: objections, anyone need more context?
<fantasai> emilio: would like someone familiar with cjk to look at it, but otherwise seems fine
<fantasai> +1 TabAtkins
<fantasai> TabAtkins: These fall back to cjk-decimal due to matching fullwidth
<emilio> TabAtkins: all fall back to cjk-decimal because of full-width, same applies to these
<emilio> RESOLVED: Change fallback for cjk-earthly-branch and cjk-heavenly-stem to cjk-decimal instead of decimal
<fantasai> RESOLVED: Republish CR

@mozilla-apprentice mozilla-apprentice mentioned this issue Jun 21, 2023
Open
@chromium-helper chromium-helper mentioned this issue Jun 21, 2023
Closed
@tabatkins tabatkins reopened this Jun 21, 2023
@vitorroriz vitorroriz mentioned this issue Jun 23, 2023
Merged
webkit-commit-queue pushed a commit to vitorroriz/WebKit that referenced this issue Jun 23, 2023
@vitorroriz
[css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem shoul…
e01c725 
…d fallback to cjk-decimal

https://bugs.webkit.org/show_bug.cgi?id=258447
rdar://111208503

Reviewed by Tim Nguyen.

cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal
according to CSSWG resolution: w3c/csswg-drafts#8975

* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt:
* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205.html:
* Source/WebCore/css/counterStyles.css:
(@counter-style cjk-earthly-branch):
(@counter-style cjk-heavenly-stem):

Canonical link: https://commits.webkit.org/265474@main
@xfq xfq added i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. i18n-clreq Chinese language enablement labels Jul 5, 2023
@w3cbot w3cbot mentioned this issue Jul 5, 2023
Closed
@xfq
Copy link
Member

xfq commented Jul 7, 2023

We discussed this issue in the Chinese Layout Task Force Teleconference.

The consensus of the task force was that cjk-decimal is an improvement over decimal. simp-chinese-informal and trad-chinese-informal are even better, but since cjk-earthly-branch and cjk-heavenly-stem do not distinguish between Simplified and Traditional Chinese, we're OK with keeping it as is (cjk-decimal).

@vitorroriz
Copy link
Author

@xfq we could create another issue for adding new styles, like: cjk-earthly-brach-simp and cjk-earthly-branch-trad each with a specific fallback.

@xfq xfq added i18n-jlreq Japanese language enablement i18n-klreq Korean language enablement labels Jul 11, 2023
mnutt pushed a commit to movableink/webkit that referenced this issue Jul 18, 2023
@vitorroriz @mnutt
[css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem shoul…
6faeb15 
…d fallback to cjk-decimal

https://bugs.webkit.org/show_bug.cgi?id=258447
rdar://111208503

Reviewed by Tim Nguyen.

cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal
according to CSSWG resolution: w3c/csswg-drafts#8975

* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt:
* LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205.html:
* Source/WebCore/css/counterStyles.css:
(@counter-style cjk-earthly-branch):
(@counter-style cjk-heavenly-stem):

Canonical link: https://commits.webkit.org/265474@main
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Nov 13, 2023
@fantasai
[css-counter-styles-3] Add cjk-decimal fallback to cjk-earthly-branch…
341bc9a 
…/cjk-heavenly-stem w3c#8975
tabatkins pushed a commit that referenced this issue Nov 13, 2023
@fantasai
[css-counter-styles-3] Add cjk-decimal fallback to cjk-earthly-branch…
1ca5521 
…/cjk-heavenly-stem #8975 (#9597)
@r12a
Copy link
Contributor

r12a commented Nov 28, 2023

These changes were added to the Ready-made Counter Styles doc editor's draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution css-counter-styles-3 Current Work i18n-clreq Chinese language enablement i18n-jlreq Japanese language enablement i18n-klreq Korean language enablement i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tabatkins @fantasai @nt1m @xfq @r12a @vitorroriz @css-meeting-bot