Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(265615@main): <attachment> icon is stretched #15520

Merged
merged 1 commit into from
Jul 4, 2023
Merged

REGRESSION(265615@main): <attachment> icon is stretched #15520

merged 1 commit into from
Jul 4, 2023

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jul 3, 2023 •
edited by webkit-early-warning-system

7fc4f61

REGRESSION(265615@main): <attachment> icon is stretched
https://bugs.webkit.org/show_bug.cgi?id=258832
rdar://111697949

Reviewed by Wenson Hsieh.

Using <img> by default will stretch the icon, adding `object-fit: contain` makes sure the original image aspect ratio is honored, restoring the old behavior.

* Source/WebCore/html/shadow/attachmentElementShadow.css:
(img#attachment-icon):

Canonical link: https://commits.webkit.org/265742@main

3f2cbd6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m requested review from cdumez and rniwa as code owners July 3, 2023 23:46
@nt1m nt1m self-assigned this Jul 3, 2023
@nt1m nt1m added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jul 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 3, 2023 •
edited

EWS run on previous version of this PR (hash 3a141ea)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m force-pushed the eng/attachment-element-Respect-icon-original-aspect-ratio branch from 3a141ea to 3eea9c6 Compare July 3, 2023 23:49
@nt1m nt1m changed the title [attachment element] REGRESSION(265615@main): Respect icon original aspect ratio REGRESSION(265615@main): <attachment> icon is stretched Jul 3, 2023
@nt1m nt1m force-pushed the eng/attachment-element-Respect-icon-original-aspect-ratio branch from 3eea9c6 to 3f2cbd6 Compare July 3, 2023 23:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 3, 2023 •
edited

EWS run on current version of this PR (hash 3f2cbd6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 3, 2023 •
edited

EWS run on previous version of this PR (hash 3eea9c6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 wincairo
  🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
⏳ 🧪 webkitpy   🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
⏳ 🧪 services ⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

squelart
squelart approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@squelart squelart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an official WK reviewer yet, but pseudo-r+ from me, thanks for fixing this so quickly!

@nt1m nt1m added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Jul 4, 2023
@nt1m
REGRESSION(265615@main): <attachment> icon is stretched
7fc4f61 
https://bugs.webkit.org/show_bug.cgi?id=258832
rdar://111697949

Reviewed by Wenson Hsieh.

Using <img> by default will stretch the icon, adding `object-fit: contain` makes sure the original image aspect ratio is honored, restoring the old behavior.

* Source/WebCore/html/shadow/attachmentElementShadow.css:
(img#attachment-icon):

Canonical link: https://commits.webkit.org/265742@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/attachment-element-Respect-icon-original-aspect-ratio branch from 3f2cbd6 to 7fc4f61 Compare July 4, 2023 01:16
@webkit-commit-queue
Copy link
Collaborator

Committed 265742@main (7fc4f61): https://commits.webkit.org/265742@main

Reviewed commits have been landed. Closing PR #15520 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7fc4f61 into WebKit:main Jul 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 4, 2023
@nt1m nt1m deleted the eng/attachment-element-Respect-icon-original-aspect-ratio branch July 4, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@squelart squelart squelart approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@hortont424 hortont424 Awaiting requested review from hortont424

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

Assignees

@nt1m nt1m

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
5 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @whsieh @squelart