-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGRESSION(265615@main): <attachment> icon is stretched #15520
REGRESSION(265615@main): <attachment> icon is stretched #15520
Conversation
EWS run on previous version of this PR (hash 3a141ea)
|
3a141ea
to
3eea9c6
Compare
3eea9c6
to
3f2cbd6
Compare
EWS run on current version of this PR (hash 3f2cbd6) |
EWS run on previous version of this PR (hash 3eea9c6)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an official WK reviewer yet, but pseudo-r+ from me, thanks for fixing this so quickly!
https://bugs.webkit.org/show_bug.cgi?id=258832 rdar://111697949 Reviewed by Wenson Hsieh. Using <img> by default will stretch the icon, adding `object-fit: contain` makes sure the original image aspect ratio is honored, restoring the old behavior. * Source/WebCore/html/shadow/attachmentElementShadow.css: (img#attachment-icon): Canonical link: https://commits.webkit.org/265742@main
3f2cbd6
to
7fc4f61
Compare
Committed 265742@main (7fc4f61): https://commits.webkit.org/265742@main Reviewed commits have been landed. Closing PR #15520 and removing active labels. |
7fc4f61
3f2cbd6
🧪 gtk-wk2🛠 🧪 merge