-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSC] Always create StructureStubInfo for op_get_by_val #1565
[JSC] Always create StructureStubInfo for op_get_by_val #1565
Conversation
Sample trace from a EWS GTK crash for this:
|
12133e7
to
a91e4d7
Compare
a91e4d7
to
98e5ba1
Compare
Found a test case:
run with |
078dcf7
to
37e9b85
Compare
37e9b85
to
d58a847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me too
d58a847
to
4c91626
Compare
4c91626
to
3576f09
Compare
Committed r295614 (251619@main): https://commits.webkit.org/251619@main Reviewed commits have been landed. Closing PR #1565 and removing active labels. |
3576f09