New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gstreamer][WebRTC] webrtc/video-disabled-black.html fails #15978
Conversation
EWS run on previous version of this PR (hash c396381) |
Draft due to dependency on #15977 |
EWS run on previous version of this PR (hash c987767) |
EWS run on previous version of this PR (hash 843911d) |
The test failures exposed another GStreamer bug, MR -> https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5089 |
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
Outdated
Show resolved
Hide resolved
EWS run on previous version of this PR (hash 10421b9) |
EWS run on current version of this PR (hash 21b59d4) |
https://bugs.webkit.org/show_bug.cgi?id=254212 <rdar://problem/107046108> Reviewed by Xabier Rodriguez-Calvar. When disabling an incoming WebRTC track the mediastreamsrc now updates and propagates the corresponding GstStream. This allows decodebin3 to properly reconfigure itself, by getting rid of the decode chain (the disabled stream is not encoded). This patch also disables the `parse-streams` property on urisourcebin for MSE and MediaStreams, it's needed mostly for buffering adaptivedemux-based streams anyway. Parsing will then be done downstream, by decodebin3, which also simplifies input stream reconfigurations that are now managed internally by decodebin3. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: (webkitMediaStreamNew): (webkitMediaStreamSrcPostStreamCollection): Canonical link: https://commits.webkit.org/266589@main
21b59d4
to
d9e6730
Compare
Committed 266589@main (d9e6730): https://commits.webkit.org/266589@main Reviewed commits have been landed. Closing PR #15978 and removing active labels. |
d9e6730
21b59d4