Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gstreamer][WebRTC] webrtc/video-disabled-black.html fails #15978

Merged
merged 1 commit into from Aug 4, 2023

Commits on Aug 4, 2023

  1. [Gstreamer][WebRTC] webrtc/video-disabled-black.html fails

    https://bugs.webkit.org/show_bug.cgi?id=254212
    <rdar://problem/107046108>
    
    Reviewed by Xabier Rodriguez-Calvar.
    
    When disabling an incoming WebRTC track the mediastreamsrc now updates and propagates the
    corresponding GstStream. This allows decodebin3 to properly reconfigure itself, by getting rid of
    the decode chain (the disabled stream is not encoded).
    
    This patch also disables the `parse-streams` property on urisourcebin for MSE and MediaStreams, it's
    needed mostly for buffering adaptivedemux-based streams anyway. Parsing will then be done
    downstream, by decodebin3, which also simplifies input stream reconfigurations that are now managed
    internally by decodebin3.
    
    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    (WebCore::MediaPlayerPrivateGStreamer::configureElement):
    * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
    (webkitMediaStreamNew):
    (webkitMediaStreamSrcPostStreamCollection):
    
    Canonical link: https://commits.webkit.org/266589@main
    philn committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d9e6730 View commit details
    Browse the repository at this point in the history