Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty switch statements generated by opcode_generator.rb #16024

Merged
merged 1 commit into from Jul 25, 2023

Conversation

iangrunert
Copy link
Contributor

@iangrunert iangrunert commented Jul 23, 2023

@iangrunert iangrunert requested a review from a team as a code owner July 23, 2023 20:50
@Ahmad-S792 Ahmad-S792 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jul 23, 2023
@aproskuryakov aproskuryakov requested a review from fujii July 24, 2023 20:06
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2023
https://bugs.webkit.org/show_bug.cgi?id=259429

Reviewed by Yusuke Suzuki.

The opcode_generator.rb was generating switch statements with no case
clauses:

```
switch (argIndex) {
    default:
      break;
}
```

This is compiled by clang into a jmp instruction to the next line. This
change only generates the switch statement if there's at least one case
clause for it.

* Source/JavaScriptCore/b3/air/opcode_generator.rb:

Canonical link: https://commits.webkit.org/266276@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266276@main (ca2d701): https://commits.webkit.org/266276@main

Reviewed commits have been landed. Closing PR #16024 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ca2d701 into WebKit:main Jul 25, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
5 participants