Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty switch statements generated by opcode_generator.rb #16024

Merged
merged 1 commit into from
Jul 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions Source/JavaScriptCore/b3/air/opcode_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -995,17 +995,17 @@ def endArchs(outp, archs)
| opcode |
outp.puts "case Opcode::#{opcode.name}:"

numArgs = opcode.custom ? 0 : opcode.overloads.map {
| overload |
overload.signature.length
}.max

if opcode.custom
outp.puts "OPGEN_RETURN(#{opcode.name}Custom::admitsStack(*this, argIndex));"
else
elsif numArgs > 0
# Switch on the argIndex.
outp.puts "switch (argIndex) {"

numArgs = opcode.overloads.map {
| overload |
overload.signature.length
}.max

numArgs.times {
| argIndex |
outp.puts "case #{argIndex}:"
Expand Down