Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance RawPointer to take function pointers as well. #1632

Merged
merged 0 commits into from
Jun 21, 2022
Merged

Enhance RawPointer to take function pointers as well. #1632

merged 0 commits into from
Jun 21, 2022

Conversation

MenloDorian
Copy link

@MenloDorian MenloDorian commented Jun 20, 2022 •
edited by webkit-commit-queue
Loading

dbdd3c4

Enhance RawPointer to take function pointers as well.
https://bugs.webkit.org/show_bug.cgi?id=241773

Reviewed by Yusuke Suzuki.

Also add PageBlock::end and PageReservation::end methods to make code a little
more readable (motivated by a RawPointer use).

* Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:
(JSContextGroupAddMarkingConstraint):
* Source/JavaScriptCore/heap/HeapFinalizerCallback.cpp:
(JSC::HeapFinalizerCallback::dump const):
* Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
(JSC::initializeJITPageReservation):
* Source/WTF/wtf/PageBlock.h:
(WTF::PageBlock::end const):
* Source/WTF/wtf/PageReservation.h:
* Source/WTF/wtf/RawPointer.h:
(WTF::RawPointer::RawPointer):

Canonical link: https://commits.webkit.org/251685@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@MenloDorian MenloDorian requested a review from a team as a code owner June 20, 2022 03:18
@MenloDorian MenloDorian self-assigned this Jun 20, 2022
@MenloDorian MenloDorian added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. WebKit Nightly Build labels Jun 20, 2022
Constellation
Constellation approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@MenloDorian MenloDorian added the merge-queue Applied to send a pull request to merge-queue label Jun 21, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Enhance-RawPointer-to-take-function-pointers-as-well- branch from 674bfbd to dbdd3c4 Compare June 21, 2022 06:38
@webkit-commit-queue webkit-commit-queue merged commit dbdd3c4 into WebKit:main Jun 21, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed r295680 (251685@main): https://commits.webkit.org/251685@main

Reviewed commits have been landed. Closing PR #1632 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 21, 2022
@MenloDorian MenloDorian deleted the eng/Enhance-RawPointer-to-take-function-pointers-as-well- branch June 23, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@MenloDorian MenloDorian

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MenloDorian @webkit-commit-queue @Constellation @webkit-early-warning-system