[motion-path] Check if we are mid layout when setting containing block rect for ray #16633

nmoucht · 2023-08-12T00:58:35Z

`acfa97d`

[motion-path] Check if we are mid layout when setting containing block rect for ray
https://bugs.webkit.org/show_bug.cgi?id=260110
rdar://113780201

Reviewed by Simon Fraser.

On the first RenderLayer::updateTransform call the parent is mid layout, so it is
inorrect to query it about its rect size. If we have a motion path transform, set
that this RenderObject needs a transform update on the parent through the FrameView's
layout context, and have the parent call updateTransform after it has completed layout.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022.html: Added.

Canonical link: https://commits.webkit.org/267479@main

653d25c

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-08-12T00:59:33Z

EWS run on previous version of this PR (hash dcfc057)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
❌ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-08-12T01:04:24Z

EWS run on previous version of this PR (hash 06e6453)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-08-14T20:24:00Z

EWS run on previous version of this PR (hash a6edd43)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/rendering/RenderBlockFlow.h

Source/WebCore/rendering/RenderLayer.cpp

webkit-early-warning-system · 2023-08-15T02:45:46Z

EWS run on previous version of this PR (hash 5022957)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-08-15T19:56:14Z

EWS run on previous version of this PR (hash 3b896cc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-08-17T00:02:14Z

EWS run on previous version of this PR (hash d903dfd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/rendering/RenderLayerModelObject.cpp

smfr · 2023-08-17T01:35:37Z

Source/WebCore/rendering/RenderLayerModelObject.cpp

+            auto& rayPathOperation = downcast<RayPathOperation>(*pathOperation);
+            auto pathReferenceBoxRect = snapRectToDevicePixelsIfNeeded(parentBlock->transformReferenceBoxRect(parentBlock->style()), *this);
+            if (auto* containingBlockFlow = dynamicDowncast<RenderBlockFlow>(parentBlock)) {
+                if (parentBlock->needsLayout() && !containingBlockFlow->wasMarkedNeedingTransformUpdate(this)) {


It's a bit gross that this sets some state on the containingBlockFlow. Why not just change the code to always update motion path things after the containing block has finished layout?

Changed to set this state in RenderLayer::updateTransform and moved the rest to MotionPathHelper.

Not sure if RenderLayer::updateTransform() is the right place to set this state. We can either set it here or we have to set in every RenderObject subclass where we call updateLayerTransform() in the individual layout() functions.

Moved the marking of needing a transform update to RenderLayerModelObject::updateLayerTransform.

Source/WebCore/rendering/RenderBlockFlow.h

Source/WebCore/rendering/RenderBlockFlow.cpp

webkit-early-warning-system · 2023-08-19T03:10:45Z

EWS run on previous version of this PR (hash df4af25)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-08-28T21:24:32Z

EWS run on previous version of this PR (hash 0f378d6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	❌ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-08-28T21:24:33Z

EWS run on previous version of this PR (hash a423034)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	⏳ 🛠 wincairo
~~🧪 bindings~~	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🛠 gtk~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
⏳ 🧪 services	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-08-28T21:27:09Z

EWS run on previous version of this PR (hash a716265)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-08-29T21:02:15Z

EWS run on previous version of this PR (hash 1cb7aaa)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/page/LocalFrameViewLayoutContext.h

smfr · 2023-08-30T00:31:16Z

Source/WebCore/rendering/RenderBlock.cpp

@@ -3548,4 +3548,14 @@ LayoutUnit RenderBlock::layoutOverflowLogicalBottom(const RenderBlock& renderer)
    return std::max(renderer.clientLogicalBottom(), maxChildLogicalBottom + renderer.paddingAfter());
 }

+void RenderBlock::updateDescendantTransformsAfterLayout()
+{
+    auto descendants = view().frameView().layoutContext().descendantsNeedingTransformUpdate(this);


It could still be takeBoxesNeedingTransformUpdateAfterContainerLayout() which would extract them from the hash map, and remove the need for finishedUpdatingDescendants().

Source/WebCore/page/LocalFrameViewLayoutContext.cpp

webkit-early-warning-system · 2023-08-30T18:29:22Z

EWS run on previous version of this PR (hash af3d612)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-08-30T18:29:24Z

EWS run on previous version of this PR (hash 6db36a2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	❌ 🛠 wpe	⏳ 🛠 wincairo
~~🧪 bindings~~	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🛠 gtk~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
⏳ 🧪 services	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-08-30T19:48:35Z

EWS run on previous version of this PR (hash e32fb19)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022.html

Source/WebCore/rendering/RenderLayerModelObject.cpp

webkit-early-warning-system · 2023-08-31T00:17:35Z

EWS run on current version of this PR (hash 653d25c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

…k rect for ray https://bugs.webkit.org/show_bug.cgi?id=260110 rdar://113780201 Reviewed by Simon Fraser. On the first RenderLayer::updateTransform call the parent is mid layout, so it is inorrect to query it about its rect size. If we have a motion path transform, set that this RenderObject needs a transform update on the parent through the FrameView's layout context, and have the parent call updateTransform after it has completed layout. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022.html: Added. Canonical link: https://commits.webkit.org/267479@main

webkit-commit-queue · 2023-08-31T02:11:00Z

Committed 267479@main (acfa97d): https://commits.webkit.org/267479@main

Reviewed commits have been landed. Closing PR #16633 and removing active labels.

nmoucht self-assigned this Aug 12, 2023

nmoucht added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Aug 12, 2023

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from dcfc057 to 06e6453 Compare August 12, 2023 01:04

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 12, 2023

nmoucht removed the merging-blocked Applied to prevent a change from being merged label Aug 14, 2023

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from 06e6453 to a6edd43 Compare August 14, 2023 20:23

nmoucht requested a review from smfr August 14, 2023 23:49

smfr reviewed Aug 15, 2023

View reviewed changes

Source/WebCore/rendering/RenderBlockFlow.h Outdated Show resolved Hide resolved

Source/WebCore/rendering/RenderLayer.cpp Outdated Show resolved Hide resolved

Source/WebCore/rendering/RenderLayer.cpp Outdated Show resolved Hide resolved

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from a6edd43 to 5022957 Compare August 15, 2023 02:45

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 15, 2023

nmoucht removed the merging-blocked Applied to prevent a change from being merged label Aug 15, 2023

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from 5022957 to 3b896cc Compare August 15, 2023 19:31

nmoucht requested a review from smfr August 15, 2023 21:14

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from 3b896cc to d903dfd Compare August 17, 2023 00:02

smfr reviewed Aug 17, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 17, 2023

Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Aug 18, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 18, 2023

nmoucht removed the merging-blocked Applied to prevent a change from being merged label Aug 19, 2023

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from d903dfd to df4af25 Compare August 19, 2023 03:10

nmoucht requested a review from cdumez as a code owner August 19, 2023 03:10

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 19, 2023

nmoucht removed the merging-blocked Applied to prevent a change from being merged label Aug 19, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 25, 2023

nmoucht removed the merging-blocked Applied to prevent a change from being merged label Aug 28, 2023

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch 2 times, most recently from a423034 to 0f378d6 Compare August 28, 2023 21:21

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from 0f378d6 to a716265 Compare August 28, 2023 21:26

nmoucht mentioned this pull request Aug 29, 2023

[motion-path] Refactor various parts of path operation and RenderStyle #17143

Merged

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from a716265 to 1cb7aaa Compare August 29, 2023 20:59

smfr reviewed Aug 30, 2023

View reviewed changes

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch 2 times, most recently from 6db36a2 to af3d612 Compare August 30, 2023 18:23

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from af3d612 to e32fb19 Compare August 30, 2023 19:40

nmoucht requested a review from smfr August 30, 2023 19:44

nt1m reviewed Aug 30, 2023

View reviewed changes

LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022.html Outdated Show resolved Hide resolved

nt1m reviewed Aug 30, 2023

View reviewed changes

Source/WebCore/rendering/RenderLayerModelObject.cpp Outdated Show resolved Hide resolved

smfr approved these changes Aug 31, 2023

View reviewed changes

nmoucht force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from e32fb19 to 653d25c Compare August 31, 2023 00:08

nmoucht added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 31, 2023

webkit-commit-queue force-pushed the eng/motion-path-Check-if-we-are-mid-layout-when-setting-containing-block-rect-for-ray branch from 653d25c to acfa97d Compare August 31, 2023 02:10

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 31, 2023

webkit-commit-queue merged commit acfa97d into WebKit:main Aug 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[motion-path] Check if we are mid layout when setting containing block rect for ray #16633

[motion-path] Check if we are mid layout when setting containing block rect for ray #16633

nmoucht commented Aug 12, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Aug 12, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 12, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 14, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 15, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 15, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 17, 2023 •

edited

Loading

smfr Aug 17, 2023

nmoucht Aug 19, 2023

nmoucht Aug 19, 2023

nmoucht Aug 21, 2023

webkit-early-warning-system commented Aug 19, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 28, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 28, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 28, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 29, 2023 •

edited

Loading

smfr Aug 30, 2023

webkit-early-warning-system commented Aug 30, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 30, 2023

webkit-early-warning-system commented Aug 30, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 31, 2023 •

edited

Loading

webkit-commit-queue commented Aug 31, 2023

[motion-path] Check if we are mid layout when setting containing block rect for ray #16633

[motion-path] Check if we are mid layout when setting containing block rect for ray #16633

Conversation

nmoucht commented Aug 12, 2023 • edited by webkit-early-warning-system Loading

acfa97d

webkit-early-warning-system commented Aug 12, 2023 • edited Loading

webkit-early-warning-system commented Aug 12, 2023 • edited Loading

webkit-early-warning-system commented Aug 14, 2023 • edited Loading

webkit-early-warning-system commented Aug 15, 2023 • edited Loading

webkit-early-warning-system commented Aug 15, 2023 • edited Loading

webkit-early-warning-system commented Aug 17, 2023 • edited Loading

smfr Aug 17, 2023

Choose a reason for hiding this comment

nmoucht Aug 19, 2023

Choose a reason for hiding this comment

nmoucht Aug 19, 2023

Choose a reason for hiding this comment

nmoucht Aug 21, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Aug 19, 2023 • edited Loading

webkit-early-warning-system commented Aug 28, 2023 • edited Loading

webkit-early-warning-system commented Aug 28, 2023 • edited Loading

webkit-early-warning-system commented Aug 28, 2023 • edited Loading

webkit-early-warning-system commented Aug 29, 2023 • edited Loading

smfr Aug 30, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Aug 30, 2023 • edited Loading

webkit-early-warning-system commented Aug 30, 2023

webkit-early-warning-system commented Aug 30, 2023 • edited Loading

webkit-early-warning-system commented Aug 31, 2023 • edited Loading

webkit-commit-queue commented Aug 31, 2023

nmoucht commented Aug 12, 2023 •

edited by webkit-early-warning-system

Loading

`acfa97d`

webkit-early-warning-system commented Aug 12, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 12, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 14, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 15, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 15, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 17, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 19, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 28, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 28, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 28, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 29, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 30, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 30, 2023 •

edited

Loading

webkit-early-warning-system commented Aug 31, 2023 •

edited

Loading