Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsc.cpp(3614,1): warning: function declared 'noreturn' should not return #16776

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Aug 17, 2023

6c660bb

jsc.cpp(3614,1): warning: function declared 'noreturn' should not return
https://bugs.webkit.org/show_bug.cgi?id=260330

Reviewed by Ross Kirsling.

clang-cl reported the following warnings for Windows port.

> WTF\wtf\Assertions.cpp(335,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
> JavaScriptCore\jsc.cpp(2602,1): warning: non-void function does not return a value [-Wreturn-type]
> JavaScriptCore\jsc.cpp(3614,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]

Clang-cl should take a code path of GCC for UNUSED_FUNCTION, NO_RETURN
and NO_RETURN_WITH_VALUE macros to suppress compiler warnings.

* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Compiler.h:

Canonical link: https://commits.webkit.org/266995@main

af93ef2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@fujii fujii self-assigned this Aug 17, 2023
@fujii fujii force-pushed the eng/jsc-cpp36141-warning-function-declared-noreturn-should-not-return branch from 2ba55d0 to af93ef2 Compare August 17, 2023 07:47
@fujii fujii added the merge-queue Applied to send a pull request to merge-queue label Aug 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=260330

Reviewed by Ross Kirsling.

clang-cl reported the following warnings for Windows port.

> WTF\wtf\Assertions.cpp(335,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
> JavaScriptCore\jsc.cpp(2602,1): warning: non-void function does not return a value [-Wreturn-type]
> JavaScriptCore\jsc.cpp(3614,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]

Clang-cl should take a code path of GCC for UNUSED_FUNCTION, NO_RETURN
and NO_RETURN_WITH_VALUE macros to suppress compiler warnings.

* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Compiler.h:

Canonical link: https://commits.webkit.org/266995@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/jsc-cpp36141-warning-function-declared-noreturn-should-not-return branch from af93ef2 to 6c660bb Compare August 17, 2023 09:30
@webkit-commit-queue
Copy link
Collaborator

Committed 266995@main (6c660bb): https://commits.webkit.org/266995@main

Reviewed commits have been landed. Closing PR #16776 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6c660bb into WebKit:main Aug 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 17, 2023
@fujii fujii deleted the eng/jsc-cpp36141-warning-function-declared-noreturn-should-not-return branch September 4, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants