-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsc.cpp(3614,1): warning: function declared 'noreturn' should not return #16776
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
fujii:eng/jsc-cpp36141-warning-function-declared-noreturn-should-not-return
Aug 17, 2023
Merged
jsc.cpp(3614,1): warning: function declared 'noreturn' should not return #16776
webkit-commit-queue
merged 1 commit into
WebKit:main
from
fujii:eng/jsc-cpp36141-warning-function-declared-noreturn-should-not-return
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 2ba55d0) |
rkirsling
reviewed
Aug 17, 2023
2ba55d0
to
af93ef2
Compare
EWS run on current version of this PR (hash af93ef2) |
rkirsling
approved these changes
Aug 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=260330 Reviewed by Ross Kirsling. clang-cl reported the following warnings for Windows port. > WTF\wtf\Assertions.cpp(335,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] > JavaScriptCore\jsc.cpp(2602,1): warning: non-void function does not return a value [-Wreturn-type] > JavaScriptCore\jsc.cpp(3614,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] Clang-cl should take a code path of GCC for UNUSED_FUNCTION, NO_RETURN and NO_RETURN_WITH_VALUE macros to suppress compiler warnings. * Source/WTF/wtf/Assertions.cpp: * Source/WTF/wtf/Compiler.h: Canonical link: https://commits.webkit.org/266995@main
af93ef2
to
6c660bb
Compare
Committed 266995@main (6c660bb): https://commits.webkit.org/266995@main Reviewed commits have been landed. Closing PR #16776 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6c660bb
af93ef2
π§ͺ wpe-wk2