[ANGLE] Don't lose Metal-backed contexts for non-fatal errors

[djg]

e1280c4

[ANGLE] Don't lose Metal-backed contexts for non-fatal errors
https://bugs.webkit.org/show_bug.cgi?id=261313
rdar://115152037

Reviewed by Kimmo Kinnunen.

Since Bug 257584, Any errors from Metal command buffer submission are treated as
causing a lost device.

MTLCommandBufferErrorNotPermitted is a non-fatal error that is reported when a
page with active WebGL moves to the background on iPhoneOS/iPadOS. This error is
ignored to avoid needlessly losing all WebGL contexts since they can't be
recovered once lost and need to be recreated.

* Source/ThirdParty/ANGLE/changes.diff:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm:
(rx::mtl::CommandQueue::onCommandBufferCompleted):

Canonical link: https://commits.webkit.org/267784@main

9c90757

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash fa895ab)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	❌ 🛠 tv	🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

[kkinnunen-apple]

The problem is that the submit is lossy.
For example, if we submit work that should signal an event and the system responds "not permitted" and we drop the queue to floor then the waiter will time out.

So we need to devise a way to do something useful.

I'm not sure OpenGL as an API bends to such a direction where the flushed commands aren't executed.

We should guarantee that we are not submitting work while backgrounded.

Some work related to this patch is still needed, but I'm not sure what's the strategy.

[djg]

This is a stop gap until we can guarantee that we are not submitting work while backgrounded.

The reasoning being we were submitting work in the background previously and ignore any error returned. This means that for your example, we have always been dropping the queue on the floor and not signalling the event.

[kkinnunen-apple]

ok

[webkit-early-warning-system]

EWS run on current version of this PR (hash 9c90757)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 267784@main (e1280c4): https://commits.webkit.org/267784@main

Reviewed commits have been landed. Closing PR #17573 and removing active labels.