-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-import css/css-variables WPT #17759
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
karlcow:261514-wpt-css-variables
Sep 14, 2023
Merged
re-import css/css-variables WPT #17759
webkit-commit-queue
merged 1 commit into
WebKit:main
from
karlcow:261514-wpt-css-variables
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash ddcc82e)
|
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Sep 14, 2023
karlcow
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Sep 14, 2023
karlcow
force-pushed
the
261514-wpt-css-variables
branch
from
September 14, 2023 04:04
ddcc82e
to
221d490
Compare
EWS run on previous version of this PR (hash 221d490)
|
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Sep 14, 2023
karlcow
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Sep 14, 2023
karlcow
force-pushed
the
261514-wpt-css-variables
branch
from
September 14, 2023 08:23
221d490
to
0795a16
Compare
EWS run on current version of this PR (hash 0795a16) |
anttijk
approved these changes
Sep 14, 2023
webkit-commit-queue
force-pushed
the
261514-wpt-css-variables
branch
from
September 14, 2023 13:40
0795a16
to
96f8232
Compare
https://bugs.webkit.org/show_bug.cgi?id=261514 rdar://115430916 Reviewed by Antti Koivisto. Reimporting imported/w3c/web-platform-tests/css/css-variables/ for fixing and finishing https://bugs.webkit.org/show_bug.cgi?id=260346 There seems to be a regression for /css/css-variables/variable-definition.html which I tracked on https://bugs.webkit.org/show_bug.cgi?id=261546 WPT Import commit: 9593290 * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/long-variable-reference-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-shadow-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-shadow-properties.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/whitespace-in-fallback-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-ref.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback.html. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/267986@main
webkit-commit-queue
force-pushed
the
261514-wpt-css-variables
branch
from
September 14, 2023 13:43
96f8232
to
83f8b4c
Compare
Committed 267986@main (83f8b4c): https://commits.webkit.org/267986@main Reviewed commits have been landed. Closing PR #17759 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
83f8b4c
0795a16