Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-import css/css-variables WPT #17759

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Sep 14, 2023

83f8b4c

re-import css/css-variables WPT
https://bugs.webkit.org/show_bug.cgi?id=261514
rdar://115430916

Reviewed by Antti Koivisto.

Reimporting imported/w3c/web-platform-tests/css/css-variables/
for fixing and finishing https://bugs.webkit.org/show_bug.cgi?id=260346

There seems to be a regression for
/css/css-variables/variable-definition.html
which I tracked on https://bugs.webkit.org/show_bug.cgi?id=261546

WPT Import commit: 9593290

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/long-variable-reference-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-shadow-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-shadow-properties.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/whitespace-in-fallback-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-ref.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback.html.
* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/267986@main

0795a16

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@karlcow karlcow self-assigned this Sep 14, 2023
@karlcow karlcow added the CSS Cascading Style Sheets implementation label Sep 14, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 14, 2023
@karlcow karlcow removed the merging-blocked Applied to prevent a change from being merged label Sep 14, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 14, 2023
@karlcow karlcow removed the merging-blocked Applied to prevent a change from being merged label Sep 14, 2023
@karlcow karlcow requested a review from nt1m September 14, 2023 11:55
@karlcow karlcow added the merge-queue Applied to send a pull request to merge-queue label Sep 14, 2023
https://bugs.webkit.org/show_bug.cgi?id=261514
rdar://115430916

Reviewed by Antti Koivisto.

Reimporting imported/w3c/web-platform-tests/css/css-variables/
for fixing and finishing https://bugs.webkit.org/show_bug.cgi?id=260346

There seems to be a regression for
/css/css-variables/variable-definition.html
which I tracked on https://bugs.webkit.org/show_bug.cgi?id=261546

WPT Import commit: 9593290

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/long-variable-reference-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-shadow-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-shadow-properties.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/whitespace-in-fallback-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-ref.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-expected.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-variables/wide-keyword-fallback.html.
* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/267986@main
@webkit-commit-queue
Copy link
Collaborator

Committed 267986@main (83f8b4c): https://commits.webkit.org/267986@main

Reviewed commits have been landed. Closing PR #17759 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 83f8b4c into WebKit:main Sep 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants