Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageBuffer has unused virtual function cloneForDifferentThread() #17912

Conversation

kkinnunen-apple
Copy link
Contributor

@kkinnunen-apple kkinnunen-apple commented Sep 19, 2023

d2ed32a

ImageBuffer has unused virtual function cloneForDifferentThread()
https://bugs.webkit.org/show_bug.cgi?id=261736
rdar://115721857

Reviewed by Said Abou-Hallawa.

The function was used as the RemoteImageBufferProxy implementation of
the real payload function
ImageBuffer::sinkIntoBufferForDifferentThread().

Remove the function, it's not needed. Use the implementation to
implement RemoteImageBufferProxy::sinkIntoBufferForDifferentThread()
override.

* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::cloneForDifferentThread): Deleted.
* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::sinkIntoBufferForDifferentThread):
(WebKit::RemoteImageBufferProxy::cloneForDifferentThread): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

Canonical link: https://commits.webkit.org/268186@main

967f54d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@kkinnunen-apple kkinnunen-apple self-assigned this Sep 19, 2023
@kkinnunen-apple kkinnunen-apple added the Canvas Bugs related to the canvas element. label Sep 19, 2023
@kkinnunen-apple kkinnunen-apple requested review from mattwoodrow and shallawa and removed request for cdumez September 19, 2023 13:55
@kkinnunen-apple kkinnunen-apple added the merge-queue Applied to send a pull request to merge-queue label Sep 20, 2023
https://bugs.webkit.org/show_bug.cgi?id=261736
rdar://115721857

Reviewed by Said Abou-Hallawa.

The function was used as the RemoteImageBufferProxy implementation of
the real payload function
ImageBuffer::sinkIntoBufferForDifferentThread().

Remove the function, it's not needed. Use the implementation to
implement RemoteImageBufferProxy::sinkIntoBufferForDifferentThread()
override.

* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::cloneForDifferentThread): Deleted.
* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::sinkIntoBufferForDifferentThread):
(WebKit::RemoteImageBufferProxy::cloneForDifferentThread): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

Canonical link: https://commits.webkit.org/268186@main
@webkit-commit-queue webkit-commit-queue force-pushed the imagebuffer-no-clonefordifferentthread-1 branch from 967f54d to d2ed32a Compare September 20, 2023 08:07
@webkit-commit-queue
Copy link
Collaborator

Committed 268186@main (d2ed32a): https://commits.webkit.org/268186@main

Reviewed commits have been landed. Closing PR #17912 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d2ed32a into WebKit:main Sep 20, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Canvas Bugs related to the canvas element.
Projects
None yet
4 participants