Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MediaRecorderProvider Werror build with no implementation #18274

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix MediaRecorderProvider Werror build with no implementation #18274

merged 1 commit into from
Sep 28, 2023

Conversation

blino
Copy link
Contributor

@blino blino commented Sep 27, 2023 •
edited by webkit-early-warning-system
Loading

be9844a

Fix MediaRecorderProvider Werror build with no implementation
https://bugs.webkit.org/show_bug.cgi?id=262178

Reviewed by Philippe Normand.

Flag unused parameters.

* Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:
(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):

Canonical link: https://commits.webkit.org/268573@main

a737c18

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino self-assigned this Sep 27, 2023
@blino blino added the WebRTC For bugs in WebRTC label Sep 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 27, 2023 •
edited
Loading

EWS run on current version of this PR (hash a737c18)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino added the merge-queue Applied to send a pull request to merge-queue label Sep 28, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-MediaRecorderProvider-Werror-build-with-no-implementation branch from a737c18 to 1b93c07 Compare September 28, 2023 08:31
@blino
Fix MediaRecorderProvider Werror build with no implementation
be9844a 
https://bugs.webkit.org/show_bug.cgi?id=262178

Reviewed by Philippe Normand.

Flag unused parameters.

* Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:
(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):

Canonical link: https://commits.webkit.org/268573@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-MediaRecorderProvider-Werror-build-with-no-implementation branch from 1b93c07 to be9844a Compare September 28, 2023 08:34
@webkit-commit-queue
Copy link
Collaborator

Committed 268573@main (be9844a): https://commits.webkit.org/268573@main

Reviewed commits have been landed. Closing PR #18274 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit be9844a into WebKit:main Sep 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 28, 2023
@turbomaster95 turbomaster95 mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philn philn philn approved these changes

Assignees

@blino blino

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blino @webkit-early-warning-system @webkit-commit-queue @philn