Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BBC radio player quirk leftovers #18339

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove BBC radio player quirk leftovers #18339

merged 1 commit into from
Oct 3, 2023

Conversation

blino
Copy link
Contributor

@blino blino commented Sep 28, 2023 •
edited by webkit-early-warning-system
Loading

e0366ad

Remove BBC radio player quirk leftovers
https://bugs.webkit.org/show_bug.cgi?id=262300

Reviewed by Kate Cheney and Brent Fulgham.

The BBC radio player quirk has been removed in 266597@main (9b58b4b),
which is a back-merge of 259548.824@safari-7615-branch (cff01e3).

But this commit did not remove the Quirks::staticRadioPlayerURLString() method
initially removed, and a second quirk part added in 261190@main (ae69009)
which is now irrelevant and potentially broken.

The usage of staticRadioPlayerURLString() also broke build without ITP support.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::staticRadioPlayerURLString): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):

Canonical link: https://commits.webkit.org/268769@main

e334db5

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino requested a review from cdumez as a code owner September 28, 2023 11:47
@blino blino self-assigned this Sep 28, 2023
@blino blino added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Sep 28, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 28, 2023 •
edited
Loading

EWS run on current version of this PR (hash e334db5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed -- we missed this bit of the old Quirk when we removed the rest. Thank you for catching this!

@blino blino added the merge-queue Applied to send a pull request to merge-queue label Oct 3, 2023
@blino
Copy link
Contributor Author

blino commented Oct 3, 2023

@kcheney1 @brentfulgham : thanks for the review!
This is part of more changes to fix build without ITP, see also #18545

@blino
Remove BBC radio player quirk leftovers
e0366ad 
https://bugs.webkit.org/show_bug.cgi?id=262300

Reviewed by Kate Cheney and Brent Fulgham.

The BBC radio player quirk has been removed in 266597@main (9b58b4b),
which is a back-merge of 259548.824@safari-7615-branch (cff01e3).

But this commit did not remove the Quirks::staticRadioPlayerURLString() method
initially removed, and a second quirk part added in 261190@main (ae69009)
which is now irrelevant and potentially broken.

The usage of staticRadioPlayerURLString() also broke build without ITP support.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::staticRadioPlayerURLString): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):

Canonical link: https://commits.webkit.org/268769@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-BBC-radio-player-quirk-leftovers branch from e334db5 to e0366ad Compare October 3, 2023 12:24
@webkit-commit-queue
Copy link
Collaborator

Committed 268769@main (e0366ad): https://commits.webkit.org/268769@main

Reviewed commits have been landed. Closing PR #18339 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e0366ad into WebKit:main Oct 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 3, 2023
@blino blino deleted the eng/Remove-BBC-radio-player-quirk-leftovers branch November 22, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@kcheney1 kcheney1 kcheney1 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@pascoej pascoej Awaiting requested review from pascoej

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@blino blino

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@blino @webkit-early-warning-system @webkit-commit-queue @brentfulgham @kcheney1