Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build without ITP #18545

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix build without ITP #18545

merged 1 commit into from
Oct 6, 2023

Conversation

blino
Copy link
Contributor

@blino blino commented Oct 3, 2023 •
edited by webkit-early-warning-system
Loading

a6bbf5e

Fix build without ITP
https://bugs.webkit.org/show_bug.cgi?id=262533

Reviewed by Michael Catanzaro.

* Source/WebCore/dom/Element.h:
Drive-by typo fix to rename isSyntheticClick variable as isSyntheticClick

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
Flag isSyntheticClick usage added in 238929@main (98bc1318d160)

* Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::getRawCookies const):
(WebCore::cookiesForSession):
Flag shouldRelaxThirdPartyCookieBlocking usage added in 225134@main (664f22663e8d)

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
Include HashCountedSet.h to fix build of MessageReceiver objects without ITP

* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::fireNotificationEvent):
Flag resourceLoadStatistics() usage added in 255816@main (9404eeeb89ae)

* Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
Include WebsiteDataType.h for WebsiteDataType::DiskCache usage

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Flag RequestStorageAccessResult struct moved in 259893@main (cbe22e46962f)

Canonical link: https://commits.webkit.org/268975@main

eaa8ac0

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino requested review from a team, cdumez and rniwa as code owners October 3, 2023 11:47
@blino blino self-assigned this Oct 3, 2023
@blino blino added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Oct 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 3, 2023 •
edited
Loading

EWS run on current version of this PR (hash eaa8ac0)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino mentioned this pull request Oct 3, 2023
Merged
mcatanzaro
mcatanzaro reviewed Oct 3, 2023
View reviewed changes
Source/WebCore/dom/Element.h
@@ -620,7 +620,7 @@ class Element : public ContainerNode {
IntPoint savedLayerScrollPosition() const;
void setSavedLayerScrollPosition(const IntPoint&);

bool dispatchMouseEvent(const PlatformMouseEvent&, const AtomString& eventType, int clickCount = 0, Element* relatedTarget = nullptr, IsSyntheticClick isSyntethicClick = IsSyntheticClick::No);
bool dispatchMouseEvent(const PlatformMouseEvent&, const AtomString& eventType, int clickCount = 0, Element* relatedTarget = nullptr, IsSyntheticClick isSyntheticClick = IsSyntheticClick::No);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please placate the style checker:

ERROR: Source/WebCore/dom/Element.h:623:  The parameter name "isSyntheticClick" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files

@blino blino added the merge-queue Applied to send a pull request to merge-queue label Oct 6, 2023
@blino
Fix build without ITP
a6bbf5e 
https://bugs.webkit.org/show_bug.cgi?id=262533

Reviewed by Michael Catanzaro.

* Source/WebCore/dom/Element.h:
Drive-by typo fix to rename isSyntheticClick variable as isSyntheticClick

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
Flag isSyntheticClick usage added in 238929@main (98bc131)

* Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::getRawCookies const):
(WebCore::cookiesForSession):
Flag shouldRelaxThirdPartyCookieBlocking usage added in 225134@main (664f226)

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
Include HashCountedSet.h to fix build of MessageReceiver objects without ITP

* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::fireNotificationEvent):
Flag resourceLoadStatistics() usage added in 255816@main (9404eee)

* Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
Include WebsiteDataType.h for WebsiteDataType::DiskCache usage

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Flag RequestStorageAccessResult struct moved in 259893@main (cbe22e4)

Canonical link: https://commits.webkit.org/268975@main
@webkit-commit-queue
Copy link
Collaborator

Committed 268975@main (a6bbf5e): https://commits.webkit.org/268975@main

Reviewed commits have been landed. Closing PR #18545 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a6bbf5e into WebKit:main Oct 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 6, 2023
@blino blino deleted the eng/Fix-build-without-ITP branch November 22, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

@kcheney1 kcheney1 Awaiting requested review from kcheney1

Assignees

@blino blino

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
4 participants
@blino @webkit-early-warning-system @webkit-commit-queue @mcatanzaro