setSampleBufferAsDisplayImmediately should check that attachment array is not null #18563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 865aa24)
|
brentfulgham
approved these changes
Oct 3, 2023
| @@ -357,6 +357,8 @@ static void runWithoutAnimations(const WTF::Function<void()>& function) | |||
| static void setSampleBufferAsDisplayImmediately(CMSampleBufferRef sampleBuffer) | |||
| { | |||
| CFArrayRef attachmentsArray = PAL::CMSampleBufferGetSampleAttachmentsArray(sampleBuffer, true); | |||
| if (!attachmentsArray) | |||
There was a problem hiding this comment.
Do we need to check the validity of sampleBuffer as well?
…y is not null https://bugs.webkit.org/show_bug.cgi?id=262556 rdar://115712997 Reviewed by Brent Fulgham. CMSampleBufferGetSampleAttachmentsArray may return a null attachment array even if createIfNecessary = true, in case of error. In that case, make sure setSampleBufferAsDisplayImmediately bails out early. * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm: (WebCore::setSampleBufferAsDisplayImmediately): Canonical link: https://commits.webkit.org/268802@main
webkit-commit-queue
force-pushed
the
eng/setSampleBufferAsDisplayImmediately-should-check-that-attachment-array-is-not-null
branch
from
865aa24
to
53867c1
Compare
|
Committed 268802@main (53867c1): https://commits.webkit.org/268802@main Reviewed commits have been landed. Closing PR #18563 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
53867c1
865aa24
🧪 wpe-wk2