-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setSampleBufferAsDisplayImmediately should check that attachment array is not null #18563
Conversation
EWS run on current version of this PR (hash 865aa24)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a reasonable nullptr check. r=me
@@ -357,6 +357,8 @@ static void runWithoutAnimations(const WTF::Function<void()>& function) | |||
static void setSampleBufferAsDisplayImmediately(CMSampleBufferRef sampleBuffer) | |||
{ | |||
CFArrayRef attachmentsArray = PAL::CMSampleBufferGetSampleAttachmentsArray(sampleBuffer, true); | |||
if (!attachmentsArray) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check the validity of sampleBuffer
as well?
…y is not null https://bugs.webkit.org/show_bug.cgi?id=262556 rdar://115712997 Reviewed by Brent Fulgham. CMSampleBufferGetSampleAttachmentsArray may return a null attachment array even if createIfNecessary = true, in case of error. In that case, make sure setSampleBufferAsDisplayImmediately bails out early. * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm: (WebCore::setSampleBufferAsDisplayImmediately): Canonical link: https://commits.webkit.org/268802@main
865aa24
to
53867c1
Compare
Committed 268802@main (53867c1): https://commits.webkit.org/268802@main Reviewed commits have been landed. Closing PR #18563 and removing active labels. |
53867c1
865aa24
🧪 wpe-wk2