-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WGSL] Generate the correct code for arrayLength #18697
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
tadeuzagallo:eng/WGSL-Generate-the-correct-code-for-arrayLength
Oct 6, 2023
Merged
[WGSL] Generate the correct code for arrayLength #18697
webkit-commit-queue
merged 1 commit into
WebKit:main
from
tadeuzagallo:eng/WGSL-Generate-the-correct-code-for-arrayLength
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 2757bc5)
|
mwyrzykowski
previously approved these changes
Oct 5, 2023
mwyrzykowski
approved these changes
Oct 5, 2023
Approval is based on having the compiler error fixed, but I tried the change and it works great |
2757bc5
to
4091e28
Compare
EWS run on current version of this PR (hash 4091e28)
|
https://bugs.webkit.org/show_bug.cgi?id=262703 rdar://116524838 Reviewed by Mike Wyrzykowski. As of 268884@main, the API now exposes the size of runtime-sized arrays at the end of the argument buffer. This patch updates the compiler to match this argument buffer layout and rewrite calls to arrayLength to read these sizes. * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::getPacking): (WGSL::RewriteGlobalVariables::collectGlobals): (WGSL::RewriteGlobalVariables::containsRuntimeArray): (WGSL::RewriteGlobalVariables::packArrayType): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::emitArrayLength): (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/tests/valid/array-length.wgsl: Added. Canonical link: https://commits.webkit.org/268995@main
4091e28
to
8f80944
Compare
Committed 268995@main (8f80944): https://commits.webkit.org/268995@main Reviewed commits have been landed. Closing PR #18697 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8f80944
4091e28
🧪 wpe-wk2🧪 mac-AS-debug-wk2