-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS Fonts] font-size-adjust adopts ValueType and isNone(). #18833
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
shivamidow:eng/font-size-adjust-value-type
Oct 10, 2023
Merged
[CSS Fonts] font-size-adjust adopts ValueType and isNone(). #18833
webkit-commit-queue
merged 1 commit into
WebKit:main
from
shivamidow:eng/font-size-adjust-value-type
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash a2cbbc7)
|
nt1m
approved these changes
Oct 9, 2023
a2cbbc7
to
d7d675d
Compare
EWS run on previous version of this PR (hash d7d675d) |
A merge-conflict fixed since 269084@main |
nt1m
approved these changes
Oct 9, 2023
d7d675d
to
b268180
Compare
EWS run on current version of this PR (hash b268180)
|
https://bugs.webkit.org/show_bug.cgi?id=262882 Reviewed by Tim Nguyen. To improve code readability, this change replaces a boolean with an enum class, which represents the from-font value type of FontSizeAdjust. In addition, this patch changes the boolean operator of FontSizeAdjust to an explicit method name called isNone() as a follow-up of 269041@main [1]. [1] https://commits.webkit.org/269041@main * Source/WebCore/animation/CSSPropertyAnimation.cpp: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::fontSizeAdjustFromStyle): (WebCore::fontShorthandValue): * Source/WebCore/platform/graphics/FontCascadeCache.h: (WebCore::FontDescriptionKey::FontDescriptionKey): * Source/WebCore/platform/graphics/FontCascadeFonts.h: (WebCore::FontCascadeFonts::primaryFont): * Source/WebCore/platform/graphics/FontSizeAdjust.h: (WebCore::FontSizeAdjust::isNone const): (WebCore::FontSizeAdjust::isFromFont const): (WebCore::add): (WebCore::operator<<): (WebCore::FontSizeAdjust::operator bool const): Deleted. * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertFontSizeAdjust): Canonical link: https://commits.webkit.org/269124@main
b268180
to
cfb2009
Compare
Committed 269124@main (cfb2009): https://commits.webkit.org/269124@main Reviewed commits have been landed. Closing PR #18833 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfb2009
b268180
🛠 ios🧪 wpe-wk2