Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-import css/css-text WPT #19327

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Re-import css/css-text WPT #19327

merged 1 commit into from
Oct 20, 2023

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Oct 20, 2023 •
edited by webkit-early-warning-system
Loading

afe912c

Re-import css/css-text WPT
https://bugs.webkit.org/show_bug.cgi?id=263424
rdar://117238291

Reviewed by Cameron McCormack.

Upstream commit: web-platform-tests/wpt@a07725c

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text/**/*: Added/Updated/Removed files (too long for Github)
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/269564@main

65645c9

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy   🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
loading 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2
❌ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@nt1m nt1m force-pushed the eng/Re-import-csscss-text-WPT branch from 7aae8cd to e0d2ca3 Compare October 20, 2023 02:14
@nt1m nt1m self-assigned this Oct 20, 2023
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Oct 20, 2023
heycam
heycam approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@heycam heycam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

TestExpectations changes look OK.

@nt1m nt1m added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Oct 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 20, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e0d2ca3)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl loading 🧪 ios-wk2 loading 🧪 api-mac ✅ 🛠 gtk
⏳ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc loading 🧪 api-ios ❌ 🧪 mac-wk2 loading 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-armv7
loading 🛠 tv-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch
loading 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 20, 2023
@nt1m nt1m removed merging-blocked Applied to prevent a change from being merged safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Oct 20, 2023
@nt1m nt1m force-pushed the eng/Re-import-csscss-text-WPT branch from e0d2ca3 to 65645c9 Compare October 20, 2023 07:21
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 20, 2023 •
edited
Loading

EWS run on current version of this PR (hash 65645c9)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy   🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
loading 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2
❌ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 20, 2023
@nt1m
Re-import css/css-text WPT
afe912c 
https://bugs.webkit.org/show_bug.cgi?id=263424
rdar://117238291

Reviewed by Cameron McCormack.

Upstream commit: web-platform-tests/wpt@a07725c

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text/**/*: Added/Updated/Removed files (too long for Github)
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/269564@main
@webkit-commit-queue webkit-commit-queue merged commit afe912c into WebKit:main Oct 20, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 269564@main (afe912c): https://commits.webkit.org/269564@main

Reviewed commits have been landed. Closing PR #19327 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 20, 2023
@nt1m nt1m deleted the eng/Re-import-csscss-text-WPT branch October 20, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heycam heycam heycam approved these changes

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @heycam @webkit-ews-buildbot