Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (269411@main): [ Sonoma wk2 ] fast/selectors/text-field-selection-stroke-color.html is flakily failing #19411

Merged
merged 1 commit into from
Oct 25, 2023
Merged

REGRESSION (269411@main): [ Sonoma wk2 ] fast/selectors/text-field-selection-stroke-color.html is flakily failing #19411

merged 1 commit into from
Oct 25, 2023

Conversation

anttijk
Copy link
Contributor

@anttijk anttijk commented Oct 23, 2023 •
edited by webkit-early-warning-system
Loading

544bf66

REGRESSION (269411@main): [ Sonoma wk2 ] fast/selectors/text-field-selection-stroke-color.html is flakily failing
https://bugs.webkit.org/show_bug.cgi?id=263407
rdar://117225774

Unreviewed test fixing.

* LayoutTests/fast/selectors/text-field-selection-stroke-color.html:

Add little bit of fuzziness. For some reason there is variance in some text edges.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/269751@main

fe1b2b2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk self-assigned this Oct 23, 2023
@anttijk anttijk added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Oct 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 23, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 75c9f8b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 23, 2023
@anttijk anttijk removed the merging-blocked Applied to prevent a change from being merged label Oct 23, 2023
@anttijk anttijk force-pushed the fix-text-field-selection-stroke-color branch from 75c9f8b to fe1b2b2 Compare October 23, 2023 15:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 23, 2023 •
edited
Loading

EWS run on current version of this PR (hash fe1b2b2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk added the merge-queue Applied to send a pull request to merge-queue label Oct 25, 2023
@anttijk
REGRESSION (269411@main): [ Sonoma wk2 ] fast/selectors/text-field-se…
544bf66 
…lection-stroke-color.html is flakily failing

https://bugs.webkit.org/show_bug.cgi?id=263407
rdar://117225774

Unreviewed test fixing.

* LayoutTests/fast/selectors/text-field-selection-stroke-color.html:

Add little bit of fuzziness. For some reason there is variance in some text edges.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/269751@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix-text-field-selection-stroke-color branch from fe1b2b2 to 544bf66 Compare October 25, 2023 08:52
@webkit-commit-queue
Copy link
Collaborator

Committed 269751@main (544bf66): https://commits.webkit.org/269751@main

Reviewed commits have been landed. Closing PR #19411 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 544bf66 into WebKit:main Oct 25, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anttijk anttijk

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@anttijk @webkit-early-warning-system @webkit-commit-queue @webkit-ews-buildbot