Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt more smart pointers in HTMLElement #19684

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Adopt more smart pointers in HTMLElement #19684

merged 1 commit into from
Oct 29, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Oct 29, 2023 •
edited by webkit-early-warning-system
Loading

6189248

Adopt more smart pointers in HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=263841

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/CustomElementReactionQueue.h:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::eventNameForEventHandlerAttribute):
(WebCore::HTMLElement::attributeChanged):
(WebCore::textToFragment):
(WebCore::HTMLElement::setInnerText):
(WebCore::HTMLElement::setOuterText):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::computeDirectionalityFromText const):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::HTMLElement::updateEffectiveDirectionality):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
(WebCore::HTMLElement::attachInternals):
(WebCore::runPopoverFocusingSteps):
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::hidePopoverInternal):
* Source/WebCore/html/HTMLElement.h:

Canonical link: https://commits.webkit.org/269910@main

2bb73ca

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez requested a review from rniwa as a code owner October 29, 2023 01:43
@cdumez cdumez self-assigned this Oct 29, 2023
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Oct 29, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 29, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a3d62d3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 29, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 29, 2023
@cdumez cdumez force-pushed the 263841_HTMLElement_smart_pointers branch from a3d62d3 to 2bb73ca Compare October 29, 2023 04:24
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 29, 2023 •
edited
Loading

EWS run on current version of this PR (hash 2bb73ca)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 29, 2023
@cdumez
Adopt more smart pointers in HTMLElement
6189248 
https://bugs.webkit.org/show_bug.cgi?id=263841

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/CustomElementReactionQueue.h:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::eventNameForEventHandlerAttribute):
(WebCore::HTMLElement::attributeChanged):
(WebCore::textToFragment):
(WebCore::HTMLElement::setInnerText):
(WebCore::HTMLElement::setOuterText):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::computeDirectionalityFromText const):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::HTMLElement::updateEffectiveDirectionality):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
(WebCore::HTMLElement::attachInternals):
(WebCore::runPopoverFocusingSteps):
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::hidePopoverInternal):
* Source/WebCore/html/HTMLElement.h:

Canonical link: https://commits.webkit.org/269910@main
@webkit-commit-queue
Copy link
Collaborator

Committed 269910@main (6189248): https://commits.webkit.org/269910@main

Reviewed commits have been landed. Closing PR #19684 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6189248 into WebKit:main Oct 29, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

Assignees

@cdumez cdumez

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa @webkit-ews-buildbot