-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt more smart pointers in HTMLElement #19684
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:263841_HTMLElement_smart_pointers
Oct 29, 2023
Merged
Adopt more smart pointers in HTMLElement #19684
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:263841_HTMLElement_smart_pointers
Oct 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash a3d62d3)
|
a3d62d3
to
2bb73ca
Compare
EWS run on current version of this PR (hash 2bb73ca)
|
rniwa
approved these changes
Oct 29, 2023
https://bugs.webkit.org/show_bug.cgi?id=263841 Reviewed by Ryosuke Niwa. * Source/WebCore/dom/CustomElementReactionQueue.h: * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::eventNameForEventHandlerAttribute): (WebCore::HTMLElement::attributeChanged): (WebCore::textToFragment): (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::setOuterText): (WebCore::setHasDirAutoFlagRecursively): (WebCore::HTMLElement::computeDirectionalityFromText const): (WebCore::HTMLElement::dirAttributeChanged): (WebCore::HTMLElement::updateEffectiveDirectionality): (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged): (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged): (WebCore::HTMLElement::attachInternals): (WebCore::runPopoverFocusingSteps): (WebCore::HTMLElement::showPopover): (WebCore::HTMLElement::hidePopoverInternal): * Source/WebCore/html/HTMLElement.h: Canonical link: https://commits.webkit.org/269910@main
2bb73ca
to
6189248
Compare
Committed 269910@main (6189248): https://commits.webkit.org/269910@main Reviewed commits have been landed. Closing PR #19684 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6189248
2bb73ca