Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all of HTML's character entities in WebVTT #19879

Merged

Commits on Nov 5, 2023

  1. Support all of HTML's character entities in WebVTT

    https://bugs.webkit.org/show_bug.cgi?id=176225
    
    Reviewed by Darin Adler.
    
    WebVTT cue text tokenizer algorithm has been updated to support
    all of HTML's character entities in w3c/webvtt#253.
    This patch updates the tokenizer to align with the latest spec.
    Spec: https://w3c.github.io/webvtt/#webvtt-cue-text-tokenizer
    
    The old `EscapeState` state for handling escape characters has been
    removed in favor of new two states. And the `WEBVTT_SWITCH_TO` operation
    has been added for the purpose of enabling state transition without
    the requirement to advance the input position.
    
    * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/entities-expected.txt:
    * Source/WebCore/html/track/WebVTTTokenizer.cpp:
    (WebCore::ProcessEntity):
    (WebCore::WebVTTTokenizer::nextToken):
    
    Canonical link: https://commits.webkit.org/270240@main
    cola119 authored and Ahmad Saleem committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    023c540 View commit details
    Browse the repository at this point in the history