-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove diagnostic logging from CachedResourceLoader #20107
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Constellation:eng/Remove-diagnostic-logging-from-CachedResourceLoader
Nov 7, 2023
Merged
Remove diagnostic logging from CachedResourceLoader #20107
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Constellation:eng/Remove-diagnostic-logging-from-CachedResourceLoader
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EWS run on previous version of this PR (hash f2a50fb) |
cdumez
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f2a50fb
to
83a513c
Compare
EWS run on current version of this PR (hash 83a513c) |
https://bugs.webkit.org/show_bug.cgi?id=264340 rdar://118061900 Reviewed by Chris Dumez. These loggings are no longer used. And it turned out that they are very costly when we are just hitting memory-cached resource path. We are sampling with 5%, which means we hit this every 20 image elements for example. This patch drops it from CachedResourceLoader. We should consider removing the other loggings too in the subsequent patch. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::determineRevalidationPolicy const): (WebCore::logMemoryCacheResourceRequest): Deleted. (WebCore::logRevalidation): Deleted. (WebCore::logResourceRevalidationDecision): Deleted. * Source/WebCore/page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::noCacheKey): Deleted. (WebCore::DiagnosticLoggingKeys::noStoreKey): Deleted. (WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey): Deleted. (WebCore::DiagnosticLoggingKeys::isExpiredKey): Deleted. (WebCore::DiagnosticLoggingKeys::inMemoryCacheKey): Deleted. (WebCore::DiagnosticLoggingKeys::reloadKey): Deleted. (WebCore::DiagnosticLoggingKeys::revalidatingKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey): Deleted. * Source/WebCore/page/DiagnosticLoggingKeys.h: Canonical link: https://commits.webkit.org/270338@main
83a513c
to
c1ff317
Compare
Committed 270338@main (c1ff317): https://commits.webkit.org/270338@main Reviewed commits have been landed. Closing PR #20107 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c1ff317
83a513c
🧪 wpe-wk2🧪 api-mac🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2