Remove diagnostic logging from CachedResourceLoader #20107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
Page Loading
|
EWS run on previous version of this PR (hash f2a50fb) |
webkit-ews-buildbot
added
the
merging-blocked
Constellation
removed
the
merging-blocked
Constellation
force-pushed
the
eng/Remove-diagnostic-logging-from-CachedResourceLoader
branch
from
f2a50fb
to
83a513c
Compare
|
EWS run on current version of this PR (hash 83a513c) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=264340 rdar://118061900 Reviewed by Chris Dumez. These loggings are no longer used. And it turned out that they are very costly when we are just hitting memory-cached resource path. We are sampling with 5%, which means we hit this every 20 image elements for example. This patch drops it from CachedResourceLoader. We should consider removing the other loggings too in the subsequent patch. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::determineRevalidationPolicy const): (WebCore::logMemoryCacheResourceRequest): Deleted. (WebCore::logRevalidation): Deleted. (WebCore::logResourceRevalidationDecision): Deleted. * Source/WebCore/page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::noCacheKey): Deleted. (WebCore::DiagnosticLoggingKeys::noStoreKey): Deleted. (WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey): Deleted. (WebCore::DiagnosticLoggingKeys::isExpiredKey): Deleted. (WebCore::DiagnosticLoggingKeys::inMemoryCacheKey): Deleted. (WebCore::DiagnosticLoggingKeys::reloadKey): Deleted. (WebCore::DiagnosticLoggingKeys::revalidatingKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey): Deleted. (WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey): Deleted. * Source/WebCore/page/DiagnosticLoggingKeys.h: Canonical link: https://commits.webkit.org/270338@main
webkit-commit-queue
force-pushed
the
eng/Remove-diagnostic-logging-from-CachedResourceLoader
branch
from
83a513c
to
c1ff317
Compare
|
Committed 270338@main (c1ff317): https://commits.webkit.org/270338@main Reviewed commits have been landed. Closing PR #20107 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/Remove-diagnostic-logging-from-CachedResourceLoader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c1ff317
83a513c
🧪 wpe-wk2🧪 api-mac🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2