-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple iframes in same isolated process results in one of them not being drawn. #20120
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mattwoodrow:eng/double-isolated-iframe
Nov 8, 2023
Merged
Multiple iframes in same isolated process results in one of them not being drawn. #20120
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mattwoodrow:eng/double-isolated-iframe
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on current version of this PR (hash 127406d) |
This is great, skipping test on iOS in #20176 |
achristensen07
approved these changes
Nov 8, 2023
webkit-commit-queue
pushed a commit
to achristensen07/WebKit
that referenced
this pull request
Nov 8, 2023
https://bugs.webkit.org/show_bug.cgi?id=264422 Unreviewed. WebKit#20120 added a new test that fails on iOS because of some unrelated drawing issues that also affect other site-isolation tests. Skip this new test like we do the others until the underlying issue is fixed. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/270398@main
…being drawn. https://bugs.webkit.org/show_bug.cgi?id=264356 <rdar://118034981> Reviewed by Alex Christensen. RemoteLayerBackingStoreCollection::willCommitLayerTree collects all the backing stores that were unreachable, and includes that list in the transaction so that the UI process can ensure the buffer references are removed. This changes moves that call until we've finished building all the transactions, so that were not considering buffers only used in latter transactions to be unreachable for the first transaction. It also adds a new 'willBuildTransaction' function. The set of backing stores that need display is a property of the transaction (where we call prepareBuffersForDisplay, and then paint them), so we want to clear this state per-transaction, not per rendering update. * LayoutTests/http/tests/site-isolation/double-iframe-expected.html: Added. * LayoutTests/http/tests/site-isolation/double-iframe.html: Added. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: (WebKit::RemoteLayerBackingStoreCollection::willFlushLayers): (WebKit::RemoteLayerBackingStoreCollection::willBuildTransaction): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::updateRendering): Canonical link: https://commits.webkit.org/270399@main
127406d
to
bb4da53
Compare
Committed 270399@main (bb4da53): https://commits.webkit.org/270399@main Reviewed commits have been landed. Closing PR #20120 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bb4da53
127406d