Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation failures on ARM64 linux #20143

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix compilation failures on ARM64 linux #20143

merged 1 commit into from
Nov 8, 2023

Conversation

jyavenard
Copy link
Member

@jyavenard jyavenard commented Nov 8, 2023 •
edited by webkit-early-warning-system

1755d48

Fix compilation failures on ARM64 linux
https://bugs.webkit.org/show_bug.cgi?id=264380
rdar://118093158

Reviewed by Yusuke Suzuki.

Fixing a few "error: comparison of unsigned expression in ‘>= 0’ is always true [-Werror=type-limits]"
and "error: suggest parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]".

* Source/JavaScriptCore/assembler/testmasm.cpp:
(JSC::testExtractUnsignedBitfield64):
(JSC::testInsertUnsignedBitfieldInZero32):
(JSC::testInsertUnsignedBitfieldInZero64):
(JSC::testInsertBitField32):
(JSC::testInsertBitField64):
(JSC::testExtractInsertBitfieldAtLowEnd32):
(JSC::testExtractInsertBitfieldAtLowEnd64):
(JSC::testClearBitField32):
(JSC::testClearBitField64):
(JSC::testInsertSignedBitfieldInZero32):
(JSC::testInsertSignedBitfieldInZero64):
(JSC::testExtractSignedBitfield32):
(JSC::testExtractSignedBitfield64):
(JSC::testExtractRegister32):
(JSC::testExtractRegister64):
(JSC::testZeroExtend48ToWord):

Canonical link: https://commits.webkit.org/270371@main

603ea23

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
❌ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ⏳ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@jyavenard jyavenard requested a review from a team as a code owner November 8, 2023 03:45
@jyavenard jyavenard self-assigned this Nov 8, 2023
@jyavenard jyavenard added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Nov 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 8, 2023 •
edited

EWS run on current version of this PR (hash 603ea23)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
❌ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ⏳ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

Constellation
Constellation approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@jyavenard jyavenard added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Nov 8, 2023
@jyavenard
Fix compilation failures on ARM64 linux
1755d48 
https://bugs.webkit.org/show_bug.cgi?id=264380
rdar://118093158

Reviewed by Yusuke Suzuki.

Fixing a few "error: comparison of unsigned expression in ‘>= 0’ is always true [-Werror=type-limits]"
and "error: suggest parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]".

* Source/JavaScriptCore/assembler/testmasm.cpp:
(JSC::testExtractUnsignedBitfield64):
(JSC::testInsertUnsignedBitfieldInZero32):
(JSC::testInsertUnsignedBitfieldInZero64):
(JSC::testInsertBitField32):
(JSC::testInsertBitField64):
(JSC::testExtractInsertBitfieldAtLowEnd32):
(JSC::testExtractInsertBitfieldAtLowEnd64):
(JSC::testClearBitField32):
(JSC::testClearBitField64):
(JSC::testInsertSignedBitfieldInZero32):
(JSC::testInsertSignedBitfieldInZero64):
(JSC::testExtractSignedBitfield32):
(JSC::testExtractSignedBitfield64):
(JSC::testExtractRegister32):
(JSC::testExtractRegister64):
(JSC::testZeroExtend48ToWord):

Canonical link: https://commits.webkit.org/270371@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Compilation-failure-on-ARM64-linux branch from 603ea23 to 1755d48 Compare November 8, 2023 05:38
@webkit-commit-queue
Copy link
Collaborator

Committed 270371@main (1755d48): https://commits.webkit.org/270371@main

Reviewed commits have been landed. Closing PR #20143 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1755d48 into WebKit:main Nov 8, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 8, 2023
@jyavenard jyavenard deleted the eng/Compilation-failure-on-ARM64-linux branch December 3, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@jyavenard jyavenard

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@jyavenard @webkit-early-warning-system @webkit-commit-queue @Constellation