Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ macOS wk2 debug ] fast/mediastream/device-change-event-2.html is a flaky failure. #20306

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 10, 2023

2d5fd91

[ macOS wk2 debug ] fast/mediastream/device-change-event-2.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=261356
rdar://115192271

Reviewed by Jean-Yves Avenard.

We never implemented focus restrictions. The spec has been updated to use inview/visibility restrictions.
We align the implementation and the test with the spec.

* LayoutTests/fast/mediastream/device-change-event-2-expected.txt:
* LayoutTests/fast/mediastream/device-change-event-2.html:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::scheduledEventTimerFired):

Canonical link: https://commits.webkit.org/270702@main

79a6d40

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@youennf youennf self-assigned this Nov 10, 2023
@youennf youennf added the WebRTC For bugs in WebRTC label Nov 10, 2023
@youennf youennf force-pushed the eng/-macOS-wk2-debug--fastmediastreamdevice-change-event-2-html-is-a-flaky-failure- branch from fdbd5fa to 79a6d40 Compare November 10, 2023 15:08
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Nov 14, 2023
…flaky failure.

https://bugs.webkit.org/show_bug.cgi?id=261356
rdar://115192271

Reviewed by Jean-Yves Avenard.

We never implemented focus restrictions. The spec has been updated to use inview/visibility restrictions.
We align the implementation and the test with the spec.

* LayoutTests/fast/mediastream/device-change-event-2-expected.txt:
* LayoutTests/fast/mediastream/device-change-event-2.html:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::scheduledEventTimerFired):

Canonical link: https://commits.webkit.org/270702@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/-macOS-wk2-debug--fastmediastreamdevice-change-event-2-html-is-a-flaky-failure- branch from 79a6d40 to 2d5fd91 Compare November 14, 2023 10:14
@webkit-commit-queue webkit-commit-queue merged commit 2d5fd91 into WebKit:main Nov 14, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 270702@main (2d5fd91): https://commits.webkit.org/270702@main

Reviewed commits have been landed. Closing PR #20306 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebRTC For bugs in WebRTC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants