-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoEncoder produces no frames with latencyMode "realtime" when framerate/bitrate are not given #20842
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
youennf:eng/VideoEncoder-produces-no-frames-with-latencyMode-realtime-when-frameratebitrate-are-not-given
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 4d41308)
|
4d41308
to
b282432
Compare
EWS run on previous version of this PR (hash b282432) |
b282432
to
73532e8
Compare
EWS run on current version of this PR (hash 73532e8) |
eric-carlson
approved these changes
Nov 23, 2023
…erate/bitrate are not given https://bugs.webkit.org/show_bug.cgi?id=264894 rdar://118725549 Reviewed by Eric Carlson. When frame rate and/or bitrate is not set, use default values for them. For frame rate, we use 30 frames. For bitrate, we use the max bit rate as per H264 table A.1. * LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any-expected.txt: Added. * LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.html: Added. * LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.js: Added. (async encoderTest): (promise_test.async return): (promise_test): * LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.worker-expected.txt: Added. * LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.worker.html: Added. * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm: (-[RTCVideoEncoderH264 startEncodeWithSettings:numberOfCores:]): (-[RTCVideoEncoderH264 setBitrate:framerate:]): (-[RTCVideoEncoderH264 setEncoderBitrateBps:frameRate:]): Canonical link: https://commits.webkit.org/271087@main
73532e8
to
ef16bd3
Compare
Committed 271087@main (ef16bd3): https://commits.webkit.org/271087@main Reviewed commits have been landed. Closing PR #20842 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ef16bd3
73532e8