Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate serialization of webrtc::WebKitEncodedFrameInfo #20949

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Generate serialization of webrtc::WebKitEncodedFrameInfo #20949

merged 1 commit into from
Nov 27, 2023

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Nov 27, 2023 •
edited by webkit-early-warning-system

c68f7ca

Generate serialization of webrtc::WebKitEncodedFrameInfo
https://bugs.webkit.org/show_bug.cgi?id=265398
rdar://118845948

Reviewed by Chris Dumez.

* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
(webrtc::WebKitEncodedFrameInfo::decode): Deleted.
(webrtc::WebKitEncodedFrameInfo::encode const): Deleted.
* Source/WebKit/Shared/RTCNetwork.serialization.in:

Canonical link: https://commits.webkit.org/271173@main

976731d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 self-assigned this Nov 27, 2023
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Nov 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 27, 2023 •
edited

EWS run on current version of this PR (hash 976731d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 27, 2023
@achristensen07
Generate serialization of webrtc::WebKitEncodedFrameInfo
c68f7ca 
https://bugs.webkit.org/show_bug.cgi?id=265398
rdar://118845948

Reviewed by Chris Dumez.

* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
(webrtc::WebKitEncodedFrameInfo::decode): Deleted.
(webrtc::WebKitEncodedFrameInfo::encode const): Deleted.
* Source/WebKit/Shared/RTCNetwork.serialization.in:

Canonical link: https://commits.webkit.org/271173@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Generate-serialization-of-webrtcWebKitEncodedFrameInfo branch from 976731d to c68f7ca Compare November 27, 2023 22:21
@webkit-commit-queue webkit-commit-queue merged commit c68f7ca into WebKit:main Nov 27, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 271173@main (c68f7ca): https://commits.webkit.org/271173@main

Reviewed commits have been landed. Closing PR #20949 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@achristensen07 achristensen07

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@achristensen07 @webkit-early-warning-system @webkit-commit-queue @cdumez