-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] webgpu:api,operation,resource_init,texture_zero:* does not pass #21091
[WebGPU] webgpu:api,operation,resource_init,texture_zero:* does not pass #21091
Conversation
EWS run on previous version of this PR (hash deab9c4)
|
deab9c4
to
e1340b1
Compare
EWS run on previous version of this PR (hash e1340b1)
|
e1340b1
to
14a735c
Compare
EWS run on previous version of this PR (hash 14a735c)
|
14a735c
to
18b6298
Compare
EWS run on current version of this PR (hash 18b6298)
|
EWS run on current version of this PR (hash 18b6298)
|
https://bugs.webkit.org/show_bug.cgi?id=265430 <radar://118866231> Reviewed by Tadeu Zagallo. Textures are not cleared by default and we don't want to incur the cost of clearing them on creation, so track if they are loaded or copied prior to being cleared and clear if needed. Also resolve ambiguitiy that 'discard' on a render target should clear the render target, which does not seem obvious, but per gpuweb/gpuweb#4398 is intentional. * Source/WebGPU/WebGPU/CommandEncoder.h: * Source/WebGPU/WebGPU/CommandEncoder.mm: (-[TextureAndResolve initWithTexture:resolveTexture:]): (WebGPU::createSimplePso): (WebGPU::CommandEncoder::runClearEncoder): (WebGPU::CommandEncoder::beginRenderPass): (WebGPU::CommandEncoder::copyBufferToTexture): (WebGPU::CommandEncoder::clearTexture): (WebGPU::CommandEncoder::copyTextureToBuffer): (WebGPU::CommandEncoder::copyTextureToTexture): * Source/WebGPU/WebGPU/PresentationContextCoreAnimation.mm: (WebGPU::PresentationContextCoreAnimation::Configuration::generateCurrentFrameState): * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::PresentationContextIOSurface::configure): * Source/WebGPU/WebGPU/Queue.h: * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::clearTexture): (WebGPU::Queue::writeTexture): * Source/WebGPU/WebGPU/RenderPassEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::RenderPassEncoder): (WebGPU::RenderPassEncoder::executePreDrawCommands): (WebGPU::RenderPassEncoder::endPass): (WebGPU::RenderPassEncoder::executeBundles): (WebGPU::RenderPassEncoder::setScissorRect): * Source/WebGPU/WebGPU/Texture.h: * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::Texture::createView): (WebGPU::Texture::previouslyCleared const): (WebGPU::Texture::setPreviouslyCleared): * Source/WebGPU/WebGPU/TextureView.h: (WebGPU::TextureView::create): (WebGPU::TextureView::createInvalid): * Source/WebGPU/WebGPU/TextureView.mm: (WebGPU::TextureView::TextureView): (WebGPU::m_parentTexture): (WebGPU::TextureView::previouslyCleared const): (WebGPU::TextureView::setPreviouslyCleared): (WebGPU::TextureView::width const): (WebGPU::TextureView::height const): (WebGPU::m_device): Deleted. Canonical link: https://commits.webkit.org/271400@main
18b6298
to
aadb708
Compare
Committed 271400@main (aadb708): https://commits.webkit.org/271400@main Reviewed commits have been landed. Closing PR #21091 and removing active labels. |
aadb708
18b6298
🧪 wpe-wk2