Fix Lexer build with -Werror=type-limits #21169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blino
added
the
WebCore Misc.
|
EWS run on current version of this PR (hash 5e13a1e) |
darinadler
approved these changes
Dec 1, 2023
darinadler
approved these changes
Dec 1, 2023
webkit-commit-queue
force-pushed
the
eng/Fix-Lexer-build-with--Werrortype-limits
branch
from
5e13a1e
to
1d4d659
Compare
https://bugs.webkit.org/show_bug.cgi?id=265676 Reviewed by Darin Adler. After 271373@main which uses char32_t instead of UChar32, build of Lexer.cpp was broken with -Werror=type-limits codePoint is now always positive, remove the assert. * Source/JavaScriptCore/parser/Lexer.cpp: (JSC::Lexer<CharacterType>::recordUnicodeCodePoint): Canonical link: https://commits.webkit.org/271393@main
webkit-commit-queue
force-pushed
the
eng/Fix-Lexer-build-with--Werrortype-limits
branch
from
1d4d659
to
52f1f95
Compare
|
Committed 271393@main (52f1f95): https://commits.webkit.org/271393@main Reviewed commits have been landed. Closing PR #21169 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
52f1f95
5e13a1e
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🛠 🧪 jsc🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch-sim