Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lexer build with -Werror=type-limits #21169

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix Lexer build with -Werror=type-limits #21169

merged 1 commit into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. Fix Lexer build with -Werror=type-limits 

    https://bugs.webkit.org/show_bug.cgi?id=265676

Reviewed by Darin Adler.

After 271373@main which uses char32_t instead of UChar32, build of
Lexer.cpp was broken with -Werror=type-limits

codePoint is now always positive, remove the assert.

* Source/JavaScriptCore/parser/Lexer.cpp:
(JSC::Lexer<CharacterType>::recordUnicodeCodePoint):

Canonical link: https://commits.webkit.org/271393@main
    @blino @darinadler
    blino authored and darinadler committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    52f1f95 View commit details
    Browse the repository at this point in the history