New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebAuthn] Update getClientCapabilities to use record instead of maplike #22373
[WebAuthn] Update getClientCapabilities to use record instead of maplike #22373
Conversation
EWS run on previous version of this PR (hash 429a85f) |
429a85f
to
f8c1047
Compare
EWS run on previous version of this PR (hash f8c1047)
|
f8c1047
to
9d013a3
Compare
EWS run on previous version of this PR (hash 9d013a3) |
9d013a3
to
7d9ff27
Compare
EWS run on current version of this PR (hash 7d9ff27) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice to delete some files, too! r=me
rdar://120442670 https://bugs.webkit.org/show_bug.cgi?id=267068 Reviewed by Brent Fulgham. The spec has changed such that getClientCapabilities needs to return a record instead of a maplike. This patch makes that change. For more context, see the change at w3c/webauthn#1923. * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::getClientCapabilities const): * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h: * Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h: * Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp: (WebCore::PublicKeyCredential::getClientCapabilities): * Source/WebCore/Modules/webauthn/PublicKeyCredential.h: * Source/WebCore/Modules/webauthn/PublicKeyCredential.idl: * Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.cpp: Removed. * Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.h: Removed. * Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.idl: Removed. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebKit/Scripts/webkit/messages.py: (class_template_headers): * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h: * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in: Canonical link: https://commits.webkit.org/272998@main
7d9ff27
to
e595d21
Compare
Committed 272998@main (e595d21): https://commits.webkit.org/272998@main Reviewed commits have been landed. Closing PR #22373 and removing active labels. |
e595d21
7d9ff27